Yeah, the known issue doesn't always occur (hence why I haven't bothered to fix it yet) but it is odd that one game is failing and nothing else is.. All I can think is that the downloaded page with the links is formatted differently or something so the function doesn't find what it's expecting and fails.

Thanks, I'll try and look into it tomorrow and see if I can spot anything.

Ah. I see what the problem is, it is the label stuff.
I need to add a method for adding new games to the list of Ids for the updated info, in the mean time I'll put a work around in so if it doesn't find anything it shouldn't crash.

Small update

Right, this should hopefully be fixed now.
It may not show a proper update date / version yet (but I've tweaked the server code for that so hopefully it will pick up the new games as the legacy library does) but the downloader links should at least work.

Also I've tweaked the code so it shouldn't ever give you the wrong details (as there were actually quite a few instances were it was showing the goodies link for the last game you looked at say), but let me know if you find this is not the case...

Cheers.

The version + update date display correctly, but there's still something funny going on:

Indiana Jones and the Last Crusade displays no GOG Downloader link at first open, but closing it and reopening the game card brings it up.
If I disable the feature to display version + update date, then Indiana Jones and the Last Crusade displays the correct GOG Downloader link at first open.

But opening other, different games (open game card, close it, open the next, etc) is a mixed bag - sometimes they all are affected by the "keeping the last info" bug which fixes itself when reopening them, sometimes some games manage to display their correct link at first open.
I've tested this (opened my library page, clicked on games, closed it, and reopened it) four times, and there doesn't seem to be a pattern as to what games get affected and which ones don't. And the status of the "version + update date" feature (enabled or disabled) makes no difference.

A bit annoying as I didn't have this till now, but not that big of a deal; one just has to remember to double check which link they're getting, close and reopen a game card if something's off, then recheck the link, just to make sure they're downloading the correct extras.

++++++++++++

Hmmm, see that's the bug I was trying to get rid of.. I basically added a delay for the goodies function because if it fired too quickly the URL for the downloaded stuff wasn't there yet and either wouldn't show at all or would use the info from the last game.

If you leave the game cards open does it fix itself? Or is it still showing the wrong downloads after a few seconds?

Well, during my tests yesterday, the correct link would only show after closing and reopening the game card. Today, though, is a different story.

Indiana Jones and the Last Crusade displays no GOG Downloader link at first open, even with the "version + update date" feature disabled (perhaps just a coincidence that fooled me yesterday?), and it won't show no matter how long I leave the game card open - I tested this yesterday as well, and got the same result.
Closing and reopening the game card brings the link up. Which then gets picked up by the next game I open, and won't fix itself no matter how long I wait (also tested yesterday with the same result).
But games opened after show the wrong link for a couple of seconds, then it fixes itself.

Bah, that's pretty much the behavior I was trying to fix...

When you say "games opened after", do you mean any game other than Indiana Jones?

My experience was this; first game failed always, opening a second game would load the first games link as would opening any subsequent game. Opening a game you had already opened would work though.
This is basically because the info is loaded when you open the card, if the info request hasn't returned when the function calls it doesn't find anything. If you load a second game and the request for that hasn't returned it finds the first games details (which have now loaded). Reopening a game doesn't resend the request so that works fine.

I put the delay in in the hopes that the function would only ever fire once the info was returned, but obviously it's not worked. I could increase the delay but then it will become more noticeable and annoying, so I might need to find another solution instead.

Sorry, with "games opened after" I meant any games opened after the 2nd one. Which is not today's behaviour.

First test
- 1st game opened: Dragon Age: Origins - Ultimate Edition; link displayed correctly.
- 2nd game opened: Indiana Jones and the Last Crusade; link displayed correctly.
- 3rd game opened: Indiana Jones and the Fate of Atlantis; link displayed wrong for a couple of seconds, then fixed itself.
- 4th game opened: picked up link of previous game, and didn't fix itself.
- 5th game opened: link displayed correctly.
- 6th game opened: picked up link of previous game, and didn't fix itself.
- 7th game opened: link displayed correctly.

Notice a pattern?


Second test
- 1st game opened: Dragon Age: Origins - Ultimate Edition; no link displayed.
- 2nd game opened: Indiana Jones and the Last Crusade; link displayed correctly.
- 3rd game opened: Indiana Jones and the Fate of Atlantis; picked up link of previous game, and didn't fix itself.
- Every subsequent game opened after: picked up link of previous game, and didn't fix itself.

I hope the bug behaves in a more consistent manner for you, else you're going to have an incredibly hard time fixing it.

This is about the GOG downloader links on the game pages in the library, right? I noticed a similar behaviour when I switch games too quickly. Sometimes the links from the previous game are still stuck on the tab and it is easily fixed by re-opening it. I'm not using AF but the "Downloader Links on Main Library Page 0.2" script from way back when AF wasn't a thing yet. :D

Thanks for your thorough testing (as always :)), that sounds about right. That kind of behaviour is why I never got around to fixing it in the first place, because when I went to look at it it wouldn't happen...

I'm fairly sure the timing is the issue, but whacking a huge delay on it isn't really a workable solution so I'll see if there's some even I can latch on to to fire from instead or something...

Wow, people are still using that? I should probably make an updated version with the newer (better and cleaner) stuff from AF... the original one was really hacky...

You should really reconsider :)

It's probably just me at this point.

Oh I am. I'm just afraid of myself because I'd most likely spend hours sorting the library...oh no!

I am sure you will. I did the same. Seeing the sorted librarry in all of its glory and looking at the great boxart of the legacy style is nearly as much fun as playing the games. :)

Mr. Pizza...

Is it possible to see a key word search that would cover all the GOG chat logs of a user added? (i.e. I have 40 chat logs & need to key word search a term... like "big pizza" to see if it was ever mentioned)