I have picked up many supplies of different color dyes and they sell for a tidy sum at merchants.
If the only advantage in changing your armor color is the visual effect then it all seems rather pointless.

Yes, the only effect is the change of colour. And many players appreciate that.

You have found that dyes are also a good source of income, which should make things a bit easier for you...