Yes.

Are you talking about you being drunk or about the library?

Reset indeed does not work.

Thank you adaliabooks for bringing back the boxes and manual sorting!!!

Good question... ;)
I mean the library, if the old messed up order is still saved from the failed attempts that could (hopefully) be why it's doing that.

Right, I've tweaked reset and it should work now. Can you give it a try and reset your sorting and see what happens?
If the games are still in the wrong order I'll see what I can do, but hopefully that might sort it and we can get back to proper versioned updates :)

No problem amrit, glad you like it :)

Sorry.

I reset manual sort and walked through my library from page 1 to 13.
Repeated this five time (each time resetting and walking).

Here are the exceptions I got on each attempt:
1) Duplicates + empty pages
2) Everything was OK
3) W-Z on page 1, pages 12-13 did not load (no duplicates)
4) Page order incorrect, pages 12-13 did not load (no duplicates)
5) Page 11 actually contained the games of page 12 (T-W), pages 12-13 did not load (no duplicates)

Attempted once with import {} instead of reset. No better.

I see celebration was premature then..
So the duplicates thing was only an issue once and the rest of the time it looks like different problems but with a similar outcome.
When the pages didn't load what output was there in the console?
A proper page load should look like this (for any page after the first anyway):

afGetData Called page: 2
Filters not changed, product list does not need updating
Manual Sort Products
Retrieve Manual Sort Order
Manual Sort Done
Finish Data Load (Manual Sort)
Allow Manual Sort

Any other errors showing?

Previous report was at home. Now at work, tried again.

Remarkably similar results on first two attemps.
1) Duplicates + empty pages
2) Everything was OK

Then:
3) Duplicates + empty pages
4) Everything was OK
5) Everything was OK

Can't find the logic.

Me neither. It seems like just sometimes the AJAX (or something) fails or does something weird.
But the fact that it doesn't happen every time makes it difficult to figure out what exactly the issue is (because if it can work sometimes the code can't be completely broken).

I've put in safeguards against all the things I think could be causing it (AJAX returning out of sequence, AJAX being called too much, the array being sliced wrong) but while some things seem to have helped nothing has fixed it completely..

If you comment out the manual sort function (line 2647 now) what happens? Does everything work better still?

I'm struggling to see how or why the manual sort could be the issue, but evidence still suggests it might be...

I'll test it a bit later.

Perhaps you could do what MaGog does, and that is not to use AJAX at all, but simply get the HTTPS library pages (https://www.gog.com/account/getFilteredProducts?hiddenFlag=0&mediaType=1&page=1&sortBy=title&totalPages=13) synchronously one after the other. Just an idea. I don't really know how your code works.

Thanks mrkgnao, there's no rush.

I'm not sure that's possible without using AJAX (I'm no expert on Javascript but I think AJAX calls are the only way to load an external web page), but I could make them synchronous instead of asynchronous but that would lock up the UI for a bit (not too long though, even with your library I can't see the calls taking more than a minute) and it's not really recommended to do it that way.
Plus I would need to write my own method to build the urls if I did that, unless I just ignored the filters and stopped people from filtering their library when it's manually sorted...

Oh. I forgot about the filters. You're right. Forget it.

If it was just the sorting that's easy enough, but there's a lot going on with the filters and while I probably could do something, I'd rather not have to..

The safeguards I've put in place should stop the AJAX being any kind of issue (and the fact that earlier tests with manual sort commented out worked suggests it's not the AJAX, or not just the AJAX) and all the tests you guys have run have returned the results I would have expected (functions running and console logs appearing in the right order).
Despite that the AJAX is the most logical place for there to be a problem, which is why the whole thing is so puzzling..

I've gone over every relevant piece of code so many times and nothing has leapt out as being a possible problem.

Well, tested it again. I don't know what it was that you've done last, if anything, because frankly I've lost track and I always force update AF before beginning a test, but anyhow EVERYTHING WORKS FINE FOR ME NOW.

Walked ten times through my library and nothing appears to be amiss. Dragged a few games around and manual sort looks ok.

Time for HSL and MSS to confirm.

I'll test again at home.

I haven't done anything else... :S
Not that I'm complaining mind XD

Did you reset as well as walking? If not maybe I was too quick to dismiss resetting as not being the problem..

Thanks for all the effort you've put into this mrkgnao, I really appreciate it :)

We seem to see a glimmer of light at the end of the tunnel?

I'll run a test shortly and report back.

I'm not holding my breath just yet.. but maybe.

Thanks :)