Hello Zrevnur,

Thanks for the reports, it's great to see someone still attentively looking at the XML!

I'm not really set up to work on the mod anymore, but I wouldn't object to a user-made patch, so feel free to post one.

Inspiration should be fixed by switching the + 1 to * 1

The other fixes you mention would work as proposed.

There are a lot of things in your mod and also the original game which I didnt like so I have been doing more than 'looking', mostly removing or disabling things for me. Unfortunately I have also encountered many bugs in the game engine which cant be fixed by modding. The game engine is in a really sad state. The game could have been one of the top 4X games if they would have bothered to 'finish' it. Its impressive that you were able to put up with all the bugs and other issues making this mod.
As for my reports here - I am just posting them in case somebody (especially you if you ever get back to this) finds them useful.

'Arcane Construction' spell is bugged for me. Not 100% sure its a general problem. If I remove (dispel) it it does not actually get removed. The icon in the map view and the -10% effect stay. The enchantment slot however becomes 'free' so that another spell can be placed. And the icon is no longer visible in the city details view either.

Adding -1 duration fixed it for me - I also removed the unrest part as I think it was an attempted workaround for part of the issue.
<GameModifier>
<ModType>City</ModType>
<Attribute>BuildingDiscount</Attribute>
<Value>0.1</Value>
<Duration>-1</Duration>
</GameModifier>

Spell_X_Haven is also affected by the same problem. (And there may be others.)

<SpellDef InternalName="Spell_X_Raiders"> doesnt work properly for me.

Somehow the casting unit got to act multiple times as often as it should and then later (not 100% sure about the later part) it didnt get to act at all. This is after the bonus initiative was gone - at least according to the stat window.

Issue with Spell_X_Stun3 replacing Spell_X_Stun2:

Stun3 uses 'TargetKnockedProne' mechanic and Stun2 uses "ChanceToLoseNextTurn". Many units are immune to 'TargetKnockedProne' though so it is a bad "upgrade".

In addition to https://www.gog.com/forum/fallen_enchantress/felh_24_bug_list/post1 all the 'Produce xyz' improvements in Xtra are probably bugged in the same manner. I only tested <ImprovementType InternalName="Produce_X_Crystal"> and <ImprovementType InternalName="Produce_X_Power_L"> though - both had the bug.

Dont know if this originates from CoS or Xtra:

In <GameItemType InternalName="Cloak_Orvandil"> there is a mismatch between description and stats:

<GameModifier>
<ModType>Unit</ModType>
<Attribute>AdjustUnitStat</Attribute>
<StrVal>UnitStat_Defense_Pierce</StrVal>
<Value>0.4</Value>
<PerLevel>1</PerLevel>
<Provides>::: +5 DEF per 2 Levels</Provides>
</GameModifier>

(And the item is too strong and should probably be nerfed.)

<SpellDef InternalName="SummonLightbringer"> has the same bug with summon level being a hard 5.

This item can do a ranged melee attack: <GameItemType InternalName="Staff_Stag">

There are two files where it appears. Probable cause is this entry due to the staff not having a ranged attack: <TacticalRange>20</TacticalRange>

Update instructions for 2.5.1 (not yet available on GOG AFAIK) can be found here:

https://forums.elementalgame.com/451107/page/89/#3763415

Unfortunately it doesnt say if the mod still works properly with 2.5.1.

Edit: This was a user error.


Is this supposed to still work properly for 2.5.1? Because for me it doesnt show the custom resources like 'Beer' anymore (and there may be more problems which I dont know about).

Make sure you have the file XH_Resources.xml in your GOG FELH Core files folder. (Something like ...\data\English\ )

Step #2 of the installation process should fix the issue (Will move the XH_Resources.xml file from ...\Mods\0_NO\ to your GOG FELH Core files folder).

Beer is showing in Steam version.

Thanks for answer. I checked and it appears I made a mistake with my merging. Will try again.

Edit: This works now. (Unfortunately the end-turn-crashing didnt get fixed.)

--

Found some issue though: The file 'aDLC04_Units.xml' was renamed to 'DLC04_Units.xml' so its no longer overwritten by copying the 'aDLC04_Units.xml' file. Will try to delete the 'DLC04_Units.xml' and see if this works.

From my bug list thread for 2.5.1: Question: Is this fixable with modding somehow?

Old, pre-version 1.7 issue making a comeback? Probably not mod-related.
https://steamcommunity.com/app/228260/eventcomments/1644304412654080783/#c3356799628310444384

Try to see if the Wilding Shaman can cast Summon Ignys as this was a mod fix (Although I believe the only reason it worked was because of the fix in version 1.7, so if that's broken, Wilding Shaman Summon Ignys probably doesn't work either).