It seems that you're using an outdated browser. Some things may not work as they should (or don't work at all).
We suggest you upgrade newer and better browser like: Chrome, Firefox, Internet Explorer or Opera

×
Take a closer look at the screenshot of https://imgur.com/a/AT5uZfk

Only the game icons are put there, not the DLCs themselves (they are placed correctly).

Maybe it has something to do with the makeFilepath method in gamedetails.cpp, where there is a special treatment for these extra files?

https://github.com/Sude-/lgogdownloader/blob/0bae0c2160f7c2a8d9dbbcf38f9e542e18661cf7/src/gamedetails.cpp#L80
Post edited February 19, 2025 by coffeecup
avatar
coffeecup: Take a closer look at the screenshot of https://imgur.com/a/AT5uZfk

Only the game icons are put there, not the DLCs themselves (they are placed correctly).

Maybe it has something to do with the makeFilepath method in gamedetails.cpp, where there is a special treatment for these extra files?

https://github.com/Sude-/lgogdownloader/blob/0bae0c2160f7c2a8d9dbbcf38f9e542e18661cf7/src/gamedetails.cpp#L80
I was wondering why it was only those files but couldn't find anything wrong with the code that makes the file paths.
Then I noticed that I forgot to handle some of the new details when saving/loading the cache.
Should be fixed by 37788ab

37788ab Fix cache usage and add gamename to logo, icon and product json filenames
Post edited February 19, 2025 by Sude
avatar
shmerl: If there was a way to limit updating that cache by the list of game ids - that could speed things up quite a bit.
avatar
vv221: I would not bother with that. You can simply run the --update-cache operation in a daily cron job, then forget about it.
Sure, but in practice it's not faster than what I'm doing now, i.e. basically querying every installed game individually.

If your ratio of installed vs owned games is closer to 1:1 than your approach is fast enough.
Post edited February 21, 2025 by shmerl
avatar
shmerl: Sure, but in practice it's not faster than what I'm doing now, i.e. basically querying every installed game individually.
It’s obviously not going any faster that way ;)

I suggested going through cron because this way you no longer have to care how long it takes, as you are not waiting for the command completion while it is running.

---

avatar
shmerl: If your ratio of installed vs owned games is closer to 1:1 than your approach is fast enough.
This on the other hand I’m not sure to get. I don’t see any link between LGOGDownloader and installed games.
(maybe it’s related to my use case? I only use it to download offline DRM-free installers and game extras)

Just for fun my current ratio is lower than 0,009, so very far from 1:1.
avatar
vv221: This on the other hand I’m not sure to get. I don’t see any link between LGOGDownloader and installed games.
(maybe it’s related to my use case? I only use it to download offline DRM-free installers and game extras)

Just for fun my current ratio is lower than 0,009, so very far from 1:1.
The reason it's releveant for me is that I have a list of currently installed games and update them using galaxy method of lgogdownloader (or pseudo galaxy for native Linux ones). But to decide what to update I prefer first to see that something needs an update.

So my script runs over each installed game and checks if its version is behind what's on the server backend and shows me a list which highlights what's outdated.
Post edited February 23, 2025 by shmerl
avatar
shmerl: The reason it's releveant for me is that I have a list of currently installed games and update them using galaxy method of lgogdownloader (or pseudo galaxy for native Linux ones). But to decide what to update I prefer first to see that something needs an update.

So my script runs over each installed game and checks if its version is behind what's on the server backend and shows me a list which highlights what's outdated.
This could be useful for you.
cd69de7 Galaxy: Add version info to --galaxy-show-builds for linux installers
avatar
Sude: This could be useful for you.
cd69de7 Galaxy: Add version info to --galaxy-show-builds for linux installers
Oh, neat. I'll give this a try, thanks!
avatar
Sude: This could be useful for you.
cd69de7 Galaxy: Add version info to --galaxy-show-builds for linux installers
Just tested it, it works nicely and is faster than the previous method. Thanks for adding this!

Here is how I read the remote version now (in case it's a Linux game):

local remote_version=$(lgogdownloader --galaxy-platform l --galaxy-show-builds $gog_id 2>/dev/null | rg '.*\(Version: (.*)\)$' --only-matching --replace '$1' | head -1)
Post edited March 02, 2025 by shmerl
avatar
Sude: 367b57c Improve subdir filepath template handling
Adds new templates for subdir options
%title%
%title_stripped%
%dlc_title%
%dlc_title_stripped%
Since this commit and up to the current the "no-subdirectories = true" setting results in everything being put in the base directory when before it put everything into game directories as per the help info "Don't create subdirectories for extras, patches and language packs"
avatar
Sude: 367b57c Improve subdir filepath template handling
Adds new templates for subdir options
%title%
%title_stripped%
%dlc_title%
%dlc_title_stripped%
avatar
Cusith: Since this commit and up to the current the "no-subdirectories = true" setting results in everything being put in the base directory when before it put everything into game directories as per the help info "Don't create subdirectories for extras, patches and language packs"
oh, now I remember that I actually noticed that when I tested the changes.
Apparently I forgot to write that down on my notes when I was testing the changes.
So a few days later when doing fixes and cleanup on the code before pushing the commit I forgot change the behavior back to how it was previously

d8ec857 Change --no-subdirectories option behavior for game subdirectory
Post edited March 02, 2025 by Sude
avatar
Sude: oh, now I remember that I actually noticed that when I tested the changes.
Apparently I forgot to write that down on my notes when I was testing the changes.
So a few days later when doing fixes and cleanup on the code before pushing the commit I forgot change the behavior back to how it was previously

d8ec857 Change --no-subdirectories option behavior for game subdirectory
Thanks much appreciated
avatar
Sude: This could be useful for you.
cd69de7 Galaxy: Add version info to --galaxy-show-builds for linux installers
Can you please make a new tag, so Debian would pick it up before the upcoming freeze.