It seems that you're using an outdated browser. Some things may not work as they should (or don't work at all).
We suggest you upgrade newer and better browser like: Chrome, Firefox, Internet Explorer or Opera

×
Take a closer look at the screenshot of https://imgur.com/a/AT5uZfk

Only the game icons are put there, not the DLCs themselves (they are placed correctly).

Maybe it has something to do with the makeFilepath method in gamedetails.cpp, where there is a special treatment for these extra files?

https://github.com/Sude-/lgogdownloader/blob/0bae0c2160f7c2a8d9dbbcf38f9e542e18661cf7/src/gamedetails.cpp#L80
Post edited 3 days ago by coffeecup
avatar
coffeecup: Take a closer look at the screenshot of https://imgur.com/a/AT5uZfk

Only the game icons are put there, not the DLCs themselves (they are placed correctly).

Maybe it has something to do with the makeFilepath method in gamedetails.cpp, where there is a special treatment for these extra files?

https://github.com/Sude-/lgogdownloader/blob/0bae0c2160f7c2a8d9dbbcf38f9e542e18661cf7/src/gamedetails.cpp#L80
I was wondering why it was only those files but couldn't find anything wrong with the code that makes the file paths.
Then I noticed that I forgot to handle some of the new details when saving/loading the cache.
Should be fixed by 37788ab

37788ab Fix cache usage and add gamename to logo, icon and product json filenames
Post edited 3 days ago by Sude
avatar
shmerl: If there was a way to limit updating that cache by the list of game ids - that could speed things up quite a bit.
avatar
vv221: I would not bother with that. You can simply run the --update-cache operation in a daily cron job, then forget about it.
Sure, but in practice it's not faster than what I'm doing now, i.e. basically querying every installed game individually.

If your ratio of installed vs owned games is closer to 1:1 than your approach is fast enough.
Post edited Yesterday by shmerl
avatar
shmerl: Sure, but in practice it's not faster than what I'm doing now, i.e. basically querying every installed game individually.
It’s obviously not going any faster that way ;)

I suggested going through cron because this way you no longer have to care how long it takes, as you are not waiting for the command completion while it is running.

---

avatar
shmerl: If your ratio of installed vs owned games is closer to 1:1 than your approach is fast enough.
This on the other hand I’m not sure to get. I don’t see any link between LGOGDownloader and installed games.
(maybe it’s related to my use case? I only use it to download offline DRM-free installers and game extras)

Just for fun my current ratio is lower than 0,009, so very far from 1:1.