as soon as i install the game it goes black then goes back to desktop, i have messed with all the settings i can is there a fix?

It's probably because your monitor does not support 800x600 resolution. Simply connect to another monitor and try again.

First, try running WBC 3 in Windows XP Service Pack 3 Compatibility mode. Look at the WBC 3 shortcut, right click, pick properties, pick Compatibility tab, pick Windows XP Service Pack 3 or 2 is also ok. If there is no shortcut already you can do the same thing to the BattlecryIII.exe file via right click. It's the standard solution if you read forum posts or reviews for the game.

Also, back when it seemed to prefer starting up the first time in either 800x600 or 640x480 resolution. Afterwards you can bump up the resolution.

If Warlords Battlecry 3 does not run in Windows XP Service Pack 2 or 3 Compatibility mode, that's not a good sign.
It probably means you are running Windows 8 or 8.1.

With Windows 8 or 8.1 you might try downloading and installing the latest Direct X 9.0c runtime. Windows 8 and 8.1 don't have that installed as default. They instead will have Direct X 10 or later. The problem is that only Direct X 9.0c can actually successfully handle games requiring it or anything earlier in the Direct X series. So you need to add it to your system for older games. It won't interfere or break your DirectX 10 or later either.

But that still might not help. I'm just saying that without those things, you can forget it.

Now, if you can get WBC 3 running, try a similar approach on WBC 2. Keep in mind that it is possible that WBC 2 prefers Windows 98 SE, so you might try that compatibility tab. Then try to get WBC 1 working. The newer ones will probably be easier to get working. WBC 2 if you get it to work, is probably the best of the 3 games.