I would recommend you ask friends to test out the controllers they have, and see which is more comfortable and offer support for the titles you play the most.
I never had an Xbox controller, however, I did test/play at a friend house, and I didn't enjoy it very much, it was a bit uncomfortable, even now I would rather take one of my controllers with me every time I visit a friend. Most of the time I had Thrustmaster and SPEEDLINK controllers, and most of them broke because of a damaged analog stick. There was no smashing or dropping involved, it was just long time use (1-2 years, pretty often). I got the Steam controller recently, and I took it to a friends house. He tested it with a few games: first person shooter, racing, fighting and platformer. Before this, he said that the controller has a ridiculous design and appears to be very uncomfortable, but ever since he got his hands on one and tested it himself, he saw how great of a controller it actually is, and he is getting one as well.
Also, you might be able to test out controllers at a store, there are a few places with game demos for PS and Xbox games.
In the end, for me, the Steam controller is the best option, for the Linux support and the full customization.
Post edited April 08, 2016 by sanfueg