Uploading all discoveries from them main discoveries screen will not count for this milestone. You have to go to the fauna list for that specific planet where you've scanned all animals and there will be another button to upload the completed fauna list (should be at the top of the list where you can see all the different animal species on that planet). This will give you some bonus nanites for completing the list as reward and also should increase the milestone by one for each planet.