Good catch!

Yeah, since these spaces are in my database as well it's safe to say they come from GOG. Thanks for letting us know because it's easy to fix once you know.

A pleasure.

My code was stripping any unwanted spaces anyway when getting values from all fields, so I haven't been impacted that I can tell, so far.

I haven't yet checked if the extra underslash(es) in the file names impact anything though, possibly not ... other than if you were doing a check yourself. I've been busy working on the CDKey element and just done a release that supports that.

yes, the GOG API has some goof ups, intentional or not, you oughta have to run a sanitizer over it :)

Concerning if I'm a linux or Windows person: I use both, but Windows begrudgingly due to gaming; develop mostly within Windows nowadays due to the nature of my stuff.

btw watch out for some cool bogus things in Dreamfall: The Longest Journey. This is a bonus which you as an owner cannot ever download, because they put in a placeholder download, but never ever added it:

-- snip --
"galaxy_downlink_json_url" : "https://api.gog.com/products/12076xxxxxx/downlink/product_bonus/7733x",
"gamename" : "dreamfall_chapters_season_pass",
"id" : "7733x",
"language" : 1,
"name" : "Journeys Birth short stories (coming soon)",
"path" : "/dreamfall_chapters_season_pass/secureaaaa",
"platform" : 1,
"silent" : 0,
"size" : "1048576",
"type" : 2,
"updated" : 0
-- snip --

the "secureaaa" is not censored, this is literally in it.

Yeah, I recall seeing that when I bought the game, and trying to get it.

Could be that 'coming soon' means 'coming never' now.

Maybe someone should query GOG or the DEV/PUB.

I've now checked that main game file - setup_fantasy_general_ii_prologue__________1.02.11096_(40120).exe
It downloaded and checked okay with that exact file name.
So as stupid as it is, I will just leave it at that for any required future validation.
Not worth the hassle of dealing with a mismatched file name entry.
My code corrects the title for creating the game folder and that's all I really need, and that works with validation as well.

P.S. Maybe someone should tell GOG. But as it really doesn't impact anything, they probably wouldn't be in a hurry to fix it, and they do seem rather busy these days.

I have 4 files that are like that. Republique also has a "coming soon" (ie, "coming never") manual that gives a 403.

Other files return a 404. I assume they specifically set a 403 flag on "announced" files that are not yet uploaded (and when you click on them, you get a majestic white page with a 403 in black font, how glorious) and for files that they remove, but forget to also remove from the listing, its a 404.

I checked my archive, and discovered I have an earlier version file for that game that doesn't have those underslashes. Not sure if I downloaded manually or whether I used gogrepo.py back then.

If it was gogrepo.py, then it may have automatically corrected the file name. If not, then what an extra silly mistake by GOG employee or the software they use. An update doesn't need the game title to be changed for starters.

EDIT
Actually I got the updated file back in February 2021, and it has that same file name issue. I got the original in August 2020, with no file name issue. I probably used gogrepo.py for both. So no automatic fixing then.

Deleted

Yeah, that sounds about right.

Another interesting thing I discovered today, was a game name change.

I was going through my automated list of recent additions to my GOG library and one stood out as not being recent.

Tales of Monkey Island: Complete Season

I suspected a name change, and indeed it was, as it used to be just - Tales of Monkey Island

According to my updates list there is no entry for the game either, so seems a simple name change only ... unless GOG forgot to set the update flag. I will however check that out more fully ... do a comparison of files.

I've had worse. During game files downloads, I've had interruptions due to md5/size mismatch, not because of transient download errors, but because the files for a given game had been silently changed by GOG.

In each case, I had to do an update on the manifest (explicitly against the id of the affected game) + an update in the storage's actions to fix the problem and resume my downloads.

Yeah that would be a bugger.

At least in my case it seems merely a superficial change, not really impacting anything ... not the way I am parsing & saving anyway.

I've seen some here say that they have gotten partway through a large game download, only to have GOG update the files on them, and make those they got so far useless, and be required to start over. One person did not have a fast connection either, so many hours wasted. That should never happen, the last version files should still exist in their location for something like a month at least after an update added. Where's the hurry to remove the older version(s) anyway. GOG should really do the principled thing and provide older versions all the time, especially as they surely have them stored away.

I really like using gogcli.exe with my GUI, and have done for many months now.

But .....

I've had to tolerate slow download speeds, and it appears to be deliberate on GOG's part, if maybe only because they don't have enough servers in my region.

I'm not entirely sure about the server issue though, as I often get good speeds for game extras.

I should be able to get around 5 MB/s and I do if I use a program like Free Download Manager 5, or as I said, if a game extra ... in many cases.

As soon as I download an EXE or BIN file, I am only getting around 2 MB/s, using gogcli.exe ... often less. On a good day I might get up to 3.1 MB/s. A few months ago I used to always get around 5 MB/s, except in the middle of a big sale.

I cannot really blame gogcli.exe though, as I get the same slow speed using a browser link and browser downloader.

Currently I am thinking GOG are limiting the speed of a single download thread, because with FDM 5, which is multi-thread, I can get the 5 MB/s that my connection supports.

It would sure be nice, if gogcli.exe supported at least one more downloading thread. Resume would be nice too, but not as important as I have a pretty stable web connection.

The only other way to deal with this, would be to pass the file download links to FDM 5 via the command-line, but alas it only has very basic CLI support, and it doesn't deal with the format the links are in, except when you pass them via the browser. So a way to reveal the true links would be nice, though we may run afoul of the cookie requirement verification, with FDM 5 acting independently from the browser.

So right now, with any largish game download, I am back to clicking on each file download link and using FDM 5, to get a decent download speed. Clicking with ALT key held down in every case.

And then of course, I need to independently verify (validate) each downloaded file or group of files, rather than have it all done for me automatically with the one DOWNLOAD button click.

I'm away from home (and thus my home storage server) and will be for the next ~3 weeks, but I'll do some benchmarks when I get back and compare this to my home internet speed.

gogcli is technically concurrent when you download several files (the client accepts an argument dictating the max concurrency that you want), but for a single file, you are correct in your claim that it has a concurrency of 1.

The http protocol does allow you to specify ranges which would could theoretically allow higher concurrency per download, but its a fair amount of overhead (especially when you consider that I support 2 storage solutions: local disk and s3) and I'd want make sure the overhead is warranted first.