It seems that you're using an outdated browser. Some things may not work as they should (or don't work at all).
We suggest you upgrade newer and better browser like: Chrome, Firefox, Internet Explorer or Opera

×
high rated
Ok, I think it should work in Firefox now. It looks like the assignment of the AngularJS scope variable was coming to soon for some reason and not actually assigning anything, causing everything else to fail.

So I've wrapped the whole thing in a setTimeout to delay it slightly till everything's loaded correctly.

Let me know if there are any issues.

I'll start looking into the issues with votes and stuff next. For some reason it seems to stop the shortening of the reviews and adding the Read More... bit, but I'm not sure why. I suspect the two are somehow related but I'm really not sure why as I've not done anything to that side of it.

I'll also add an option for sorting by length, and a label with the total number of reviews.
Would you expect the page to reset to 1 any time you change either of the drop downs? That's probably the easiest way to stop it accidentally overrunning into empty pages when you change a setting...
high rated
avatar
adaliabooks: Ok, I think it should work in Firefox now. It looks like the assignment of the AngularJS scope variable was coming to soon for some reason and not actually assigning anything, causing everything else to fail.

So I've wrapped the whole thing in a setTimeout to delay it slightly till everything's loaded correctly.

Let me know if there are any issues.
Works great! Thank you!

Some issues/recommendations (in no particular order):
1) If using "5" reviews per page, the first page shows 4, not 5. Similarly, 9 not 10. Etc.
Checked a game with exactly 5 reviews (Afterlife) and with your script installed one sees only 4, i.e. one review gets lost.

2) I recommend displaying the current script version somewhere.

3) Consider remembering the value of "Sort Order" and "Reviews per Page" rather than always resetting them to Date, 5.

4) Voting on helpfulness no longer works. I believe you are aware of this based on your comments below.

5) Read More... is gone. I believe you are aware of this based on your comments below.
For me, it is a GREAT IMPROVEMENT, so please consider not fixing this.

6) The script is always on. Which means that when one opens a game with lots of reviews (e.g. Witcher 3), hundreds of reviews are always downloaded, even if one is not interested in reading the reviews at all. Very wasteful. This is why I suggested having a "Go" button.

7) When one opens a game with lots of reviews (e.g. Witcher 3). It takes a while for the reviews to display, which is understandable (need to download all and sort). But while this is going on, a "No Reviews Yet" message is being displayed which is confusing.

8) I assume that if one changes any of the drop-down options the reviews are just resorted and redisplayed, but not redownloaded, right? What happens when one moves out of the page? Is the array deleted? It should (to free memory), if possible.

(1), (4) and (6) are more important, I believe.

avatar
adaliabooks: I'll start looking into the issues with votes and stuff next. For some reason it seems to stop the shortening of the reviews and adding the Read More... bit, but I'm not sure why. I suspect the two are somehow related but I'm really not sure why as I've not done anything to that side of it.

I'll also add an option for sorting by length, and a label with the total number of reviews.
Would you expect the page to reset to 1 any time you change either of the drop downs? That's probably the easiest way to stop it accidentally overrunning into empty pages when you change a setting...
Reset to 1 makes sense.
Post edited September 08, 2015 by mrkgnao
high rated
avatar
adaliabooks: Ok, I think it should work in Firefox now. It looks like the assignment of the AngularJS scope variable was coming to soon for some reason and not actually assigning anything, causing everything else to fail.

So I've wrapped the whole thing in a setTimeout to delay it slightly till everything's loaded correctly.

Let me know if there are any issues.
avatar
mrkgnao: Works great! Thank you!

Some issues/recommendations (in no particular order):
1) If using "5" reviews per page, the first page shows 4, not 5. Similarly, 9 not 10. Etc.
Checked a game with exactly 5 reviews (Afterlife) and with your script installed one sees only 4, i.e. one review gets lost.

2) I recommend displaying the current script version somewhere.

3) Consider remembering the value of "Sort Order" and "Reviews per Page" rather than always resetting them to Date, 5.

4) Voting on helpfulness no longer works. I believe you are aware of this based on your comments below.

5) Read More... is gone. I believe you are aware of this based on your comments below.
For me, it is a GREAT IMPROVEMENT, so please consider not fixing this.

6) The script is always on. Which means that when one opens a game with lots of reviews (e.g. Witcher 3), hundreds of reviews are always downloaded, even if one is not interested in reading the reviews at all. Very wasteful. This is why I suggested having a "Go" button.

7) When one opens a game with lots of reviews (e.g. Witcher 3). It takes a while for the reviews to display, which is understandable (need to download all and sort). But while this is going on, a "No Reviews Yet" message is being displayed which is confusing.

8) I assume that if one changes any of the drop-down options the reviews are just resorted and redisplayed, but not redownloaded, right? What happens when one moves out of the page? Is the array deleted? It should (to free memory), if possible.

(1), (4) and (6) are more important, I believe.
1) Yeah, I noticed this myself. Bad indicing, not sure why though as I was sure I got it right... should be fixed in the next update though.

2) I'll put it in there somewhere.

3) Yeah, I need to figure out how that works and do it for the search script too...

4) Just realised that the basic implementation does more than just grab the reviews from the link, and that's why the voting doesn't work.

5) It's also why Read More doesn't work, but there is an option to switch this on and off so (assuming I can fix it) I can have an option to turn it off.

6) Fair point, I can put in a go button.

7) Not sure how easy that will be to change, all that stuff is still handled by GoG automatically... I'll look into it.

8) Yes, reviews are only downloaded once when the page is loaded and just resorted and spliced when the options are changed. Honestly... I'm not sure whether the array is deleted or not, I would assume so but I don't know the ins and outs of garbage collection in javascript.

Thanks for the feedback :)
avatar
adaliabooks: Thanks for the feedback :)
Take your time. Cheers.

BTW, with you already maintaining three major tools, you might want to consider combining them into a single suite.

Adalia Fundamentals, perhaps?
Post edited September 08, 2015 by mrkgnao
Thank you for writing your script and all the effort you are putting into it.
Much appreciated.
Sadly, not working for me, I'm getting what mrkgnao posted here.

Any ideas how to troubleshoot it?
avatar
HypersomniacLive: Sadly, not working for me, I'm getting what mrkgnao posted here.

Any ideas how to troubleshoot it?
1) Did you download the new script version?
2) Try with a game with a small number of reviews (e.g. Afterlife).
avatar
adaliabooks: Thanks for the feedback :)
avatar
mrkgnao: Take your time. Cheers.

BTW, with you already maintaining three major tools, you might want to consider combining them into a single suite.

Adalia Fundamentals, perhaps?
Yeah, it might be time for that certainly... :)

Sounds good to me, might have to borrow that ;)

avatar
solar_dome: Thank you for writing your script and all the effort you are putting into it.
Much appreciated.
No problem, I'm just glad people are using it :)

avatar
HypersomniacLive: Sadly, not working for me, I'm getting what mrkgnao posted here.

Any ideas how to troubleshoot it?
As mrkgnao suggested, are you using the latest version? I can't remember if this one auto updates properly from the first version...

If you are, can you check your console for any errors or messages? There should be a lot of stuff coming up (I think) about reviews updating and $evalAsync, or something like that.
avatar
adaliabooks: Yeah, it might be time for that certainly... :)

Sounds good to me, might have to borrow that ;)

No problem, I'm just glad people are using it :)

As mrkgnao suggested, are you using the latest version? I can't remember if this one auto updates properly from the first version...

If you are, can you check your console for any errors or messages? There should be a lot of stuff coming up (I think) about reviews updating and $evalAsync, or something like that.
I downloaded it manually shortly before posting, and it says v1.1, so it should be the latest one.

Tried Afterlife, and this is what the console has:

$evalAsync
reviewFilter.user.js:133:9
Reviews updated
reviewFilter.user.js:160:11
$evalAsync
reviewFilter.user.js:133:9
$evalAsync
reviewFilter.user.js:133:9
Reviews updated
reviewFilter.user.js:160:11
$evalAsync
reviewFilter.user.js:133:9

Copying it here messes with the formatting I see in the console, so here's also a screenshot.
reviewFilter.user.js:133:9
Attachments:
high rated
avatar
HypersomniacLive: I downloaded it manually shortly before posting, and it says v1.1, so it should be the latest one.

Tried Afterlife, and this is what the console has:

$evalAsync
reviewFilter.user.js:133:9
Reviews updated
reviewFilter.user.js:160:11
$evalAsync
reviewFilter.user.js:133:9
$evalAsync
reviewFilter.user.js:133:9
Reviews updated
reviewFilter.user.js:160:11
$evalAsync
reviewFilter.user.js:133:9

Copying it here messes with the formatting I see in the console, so here's also a screenshot.
reviewFilter.user.js:133:9
Thanks Hyper.

Not sure what the issue is... it's doing what it should be as far as I can see...

Can you paste this:
angular.element(document.getElementById('reviews')).scope()
into the console and run it and click on the green text.
Then tell me what it says under reviews.
avatar
adaliabooks: Thanks Hyper.

Not sure what the issue is... it's doing what it should be as far as I can see...

Can you paste this:
angular.element(document.getElementById('reviews')).scope()
into the console and run it and click on the green text.
Then tell me what it says under reviews.
See attachment. Not sure what you mean by "click on the green text".
Attachments:
avatar
adaliabooks: Thanks Hyper.

Not sure what the issue is... it's doing what it should be as far as I can see...

Can you paste this:
angular.element(document.getElementById('reviews')).scope()
into the console and run it and click on the green text.
Then tell me what it says under reviews.
avatar
HypersomniacLive: See attachment. Not sure what you mean by "click on the green text".
Ah, sorry in my Firefox it comes up green not blue... probably because it's the Firebug console rather than the normal one.

If you click on the bit that says Object { ... }
It should expand, and there should be an option on the list called reviews, if you can expand that and take a screenshot or tell me what it says that would be great :)
avatar
Roxolani: Thanks but I'm using Firefox. I don't see that option. Chrome-only feature?
avatar
mrkgnao: adalia is still working on it. It currently works on Chrome, but not yet on Firefox.
Good, thanks again. :)
avatar
adaliabooks: Ah, sorry in my Firefox it comes up green not blue... probably because it's the Firebug console rather than the normal one.

If you click on the bit that says Object { ... }
It should expand, and there should be an option on the list called reviews, if you can expand that and take a screenshot or tell me what it says that would be great :)
Hope I did it right.
Attachments:
avatar
Gnostic: Is it possible to sort by review length?

I find that if people who took effort in writing lengthy review would give a better picture of the game.
^^^^^^^^^^^^^^^^^^^^ soooooooooooooooooooooooo much thiiiiiiiiiiiiiiiiiiiiiiiiiiiiiisssssssssssssss !!!!!!!!!111

(I completely agree with you, but I still couldn't resist)