It seems that you're using an outdated browser. Some things may not work as they should (or don't work at all).
We suggest you upgrade newer and better browser like: Chrome, Firefox, Internet Explorer or Opera

×
Community
General discussionAdalia Fundamentals - Fixing GoG so you don't have to!(3599 posts)(3599 posts)
(3599 posts)
Pages:
1
4
5
6
7
8
50
100
150
200
240
This is my favourite topic
Posted September 24, 2015
high rated
avatar
mrkgnao: Tested DLC links:
1) Games with only DLC installers (e.g. TOME): OK downloader, OK browser
2) Games with both DLC installers and DLC bonuses (e.g. Age of Wonders 3): OK downloader, OK browser
3) Games with only DLC bonuses (e.g. Unrest): No DLC links whatsoever (nether browser, nor downloader), but the DLC goodies header is still there

Unlike ElTerprise, Din's Curse is OK.
Unlike ElTerprise, no problem with reviews ("read more..." properly gone).

I am pretty sure that at one point during testing Unrest in the last few minutes, I did see some DLC links, but now they're gone, so something is fishy.
It's ok, I know what the issue is there.

The problems is I count the containers, but when there are differing numbers of containers it won't work right. I have it set to work on the basis of the goodies showing properly when there are four containers or more, but obviously I forgot that there might be less containers if there is no DLC installer (or if there are no base extras I suppose).
Posted September 24, 2015
avatar
adaliabooks: No, don't worry about that now. Just if any errors were showing in the console, I presume their aren't if you didn't notice them.

True, but I don't know whether that would stop the links from showing at all or not. As long as the links are still showing at all that's something...
As mentioned above the downloader links now show up properly....
Posted September 24, 2015
avatar
adaliabooks: No, don't worry about that now. Just if any errors were showing in the console, I presume their aren't if you didn't notice them.

True, but I don't know whether that would stop the links from showing at all or not. As long as the links are still showing at all that's something...
avatar
ElTerprise: As mentioned above the downloader links now show up properly....
Great, you must have just been too quick getting the update before I slipped the other fix in.
Posted September 24, 2015
avatar
adaliabooks: Great, you must have just been too quick getting the update before I slipped the other fix in.
Possible. And consider me stupid. I failed to set up the review setting properly *facepalm*
That also works now :)

Edit: Aside from the problems with games that only have Bonus DLC - already mentioned by mrkgnao
Attachments:
technobabylon.jpg (83 Kb)
Post edited September 24, 2015 by ElTerprise
Posted September 24, 2015
high rated
avatar
adaliabooks: Great, you must have just been too quick getting the update before I slipped the other fix in.
avatar
ElTerprise: Possible. And consider me stupid. I failed to set up the review setting properly *facepalm*
That also works now :)

Edit: Aside from the problems with games that only have Bonus DLC - already mentioned by mrkgnao
Lol, I didn't want to ask... XD
Don't worry, I was wondering why it wasn't giving me any output yesterday and it took me five minutes to realise I'd turned debuging off... XD

Right, another little update. Hopefully that should do it, it's working for me on Lords of Xulima, but that has all four downloads and extras.

If you guys wouldn't mind testing I would be grateful :)
Posted September 24, 2015
high rated
avatar
adaliabooks: Lol, I didn't want to ask... XD
Don't worry, I was wondering why it wasn't giving me any output yesterday and it took me five minutes to realise I'd turned debuging off... XD

Right, another little update. Hopefully that should do it, it's working for me on Lords of Xulima, but that has all four downloads and extras.

If you guys wouldn't mind testing I would be grateful :)
Alright. Technobabylon now give me this in the console (i replaced my name with usr)

TypeError: angular.element(...).injector(...) is undefined account:2:8
TypeError: accountProductsScope is undefined
Stack-Trace:
compileNewDownloadLinks@file:///home/usrl/.mozilla/firefox/raegnkgj.default/gm_scripts/Adalia_Fundamentals/ada liafundamentals.user.js:1680:5
on_update@file:///home/usr/.mozilla/firefox/raegnkgj.default/gm_scripts/Adalia_Fundamentals/adaliafundamentals .user.js:1690:9
settings.onchange@file:///home/usr.mozilla/firefox/raegnkgj.default/gm_scripts/Adalia_Fundamentals/adaliafunda mentals.user.js:339:17
setDownloadOptions@file:///home/usr/.mozilla/firefox/raegnkgj.default/gm_scripts/Adalia_Fundamentals/adaliafun damentals.user.js:1693:5
@file:///home/usr/.mozilla/firefox/raegnkgj.default/gm_scripts/Adalia_Fundamentals/adaliafundamentals.user.js: 2021:13
settings.initialise@file:///home/usr/.mozilla/firefox/raegnkgj.default/gm_scripts/Adalia_Fundamentals/adaliafu ndamentals.user.js:395:19
@file:///home/usr.mozilla/firefox/raegnkgj.default/gm_scripts/Adalia_Fundamentals/adaliafundamentals.user.js:1 982:5
adaliafundamentals.user.js:2035:22


Edit: Same with Unrest. See attachment.
Attachments:
unrest.jpg (64 Kb)
Post edited September 24, 2015 by ElTerprise
Posted September 24, 2015
high rated
avatar
ElTerprise: snip
D'oh

Forgot to put the other little fix into my script before I updated it...

Force an update again and I think it should be fine (fingers crossed).
Posted September 24, 2015
avatar
adaliabooks: D'oh

Forgot to put the other little fix into my script before I updated it...

Force an update again and I think it should be fine (fingers crossed).
Well sounds like the GOG way :P

But everything works now :D.
Posted September 24, 2015
high rated
avatar
adaliabooks: D'oh

Forgot to put the other little fix into my script before I updated it...

Force an update again and I think it should be fine (fingers crossed).
avatar
ElTerprise: Well sounds like the GOG way :P

But everything works now :D.
Yay!

*waits for someone else to report an error or issue*

Boy, this software design is harder than you think...
Posted September 24, 2015
avatar
adaliabooks: Yay!

*waits for someone else to report an error or issue*

Boy, this software design is harder than you think...
Well frankly i have no idea of that so i have to take your word there :)
But i really appreciate that you invested your time to develop it. It's really useful :)
Posted September 24, 2015
high rated
avatar
adaliabooks: Yay!

*waits for someone else to report an error or issue*

Boy, this software design is harder than you think...
avatar
ElTerprise: Well frankly i have no idea of that so i have to take your word there :)
But i really appreciate that you invested your time to develop it. It's really useful :)
More usefulness to come in the future too (as long as it works... XD)
Posted September 24, 2015
high rated
avatar
adaliabooks: More usefulness to come in the future too (as long as it works... XD)
Well according to the GOG way new features are bound to break everything i'm afraid xD
Post edited September 24, 2015 by ElTerprise
Posted September 24, 2015
high rated
avatar
adaliabooks: More usefulness to come in the future too (as long as it works... XD)
avatar
ElTerprise: Well according to the GOG new features are bound to break everything i'm afraid xD
Lol.
I'm trying not to emulate GOG too closely...

But honestly, the way the site seems to be set up I'm not surprised... I'm sure there's a much more streamlined way a lot of it could be done (case in point, on the game pages there are three or four places where the reviews and total number of reviews are stored, just duplicates of the same info... I have no idea why)

But I think I've (mostly) got the hang of changing stuff now, so new features shouldn't be quite as painful as this has been to get working.
Posted September 24, 2015
high rated
avatar
adaliabooks: Lol.
I'm trying not to emulate GOG too closely...

But honestly, the way the site seems to be set up I'm not surprised... I'm sure there's a much more streamlined way a lot of it could be done (case in point, on the game pages there are three or four places where the reviews and total number of reviews are stored, just duplicates of the same info... I have no idea why)

But I think I've (mostly) got the hang of changing stuff now, so new features shouldn't be quite as painful as this has been to get working.
I see Avernum 2: Crystal Souls is on your wishlist. I happen to have an extra key for that so check your chat. You've been working extra hard so this is a very small thank you. I will see if can come up with some more keys later for you.

Thanks for all your hard work! It is really appreciated :)
Posted September 24, 2015
avatar
adaliabooks: Lol.
I'm trying not to emulate GOG too closely...

But honestly, the way the site seems to be set up I'm not surprised... I'm sure there's a much more streamlined way a lot of it could be done (case in point, on the game pages there are three or four places where the reviews and total number of reviews are stored, just duplicates of the same info... I have no idea why)

But I think I've (mostly) got the hang of changing stuff now, so new features shouldn't be quite as painful as this has been to get working.
That would be great :D
Sounds really pointless. I mean i can understand redundancies to a certain degree but that's ridiculous....
Yes. Now that it properly works the future additions should be more easy :)
Pages:
1
4
5
6
7
8
50
100
150
200
240
This is my favourite topic
Community
General discussionAdalia Fundamentals - Fixing GoG so you don't have to!(3599 posts)(3599 posts)
(3599 posts)