It seems that you're using an outdated browser. Some things may not work as they should (or don't work at all).
We suggest you upgrade newer and better browser like: Chrome, Firefox, Internet Explorer or Opera

×
Community
General discussionAdalia Fundamentals - Fixing GoG so you don't have to!(3599 posts)(3599 posts)
(3599 posts)
Pages:
1
50
54
55
56
57
58
150
200
240
This is my favourite topic
Posted January 05, 2016
high rated
avatar
HypersomniacLive: @adaliabooks

I did not try the "reset sort order" earlier. Would you like me to do so, and report on what happens?
Eh... not sure.
If you were getting the same errors with out resetting then that suggests it's not part of the problem, though it begs the question why mrkgnao started seeing issues after doing it at work...

Back up your sort order first and if you wouldn't mind trying it and seeing what happens for you that would be great.

No errors for me in either Chrome or Firefox while resetting, changing options, changing pages... Presumably quantity of games must have something to do with it (moon hasn't reported any troubles and she said she had about 300 and something) as those with larger libraries seem to get it more / worse..
Posted January 05, 2016
high rated
avatar
adaliabooks: Oh, and out of curiosity. Have all the same issues appeared? The missing pages due to the duplication error and the bad sort order you'd encountered before?
All of them.
avatar
adaliabooks: I don't really see how this can be the problem, but if someone wouldn't mind checking by commenting out line 2766 (document.dispatchEvent(new Event("manualSortEvent"));) and running through the pages of their library I'd be grateful.
Line 2766 is "else".
Version 1.3.8.
Post edited January 05, 2016 by mrkgnao
Posted January 05, 2016
high rated
avatar
mrkgnao: All of them.

Line 2766 is "else".
Version 1.3.8.
Curiouser and curiouser...

Bah, I've made some changes in my version and forgot... must remember to use the current uploaded version for line numbers. I'll find the right line number in the morning.
Posted January 05, 2016
avatar
HypersomniacLive: I did not try the "reset sort order" earlier. Would you like me to do so, and report on what happens?
But you did use import. Perhaps import does reset internally before importing?
Posted January 05, 2016
high rated
avatar
adaliabooks: Eh... not sure.
If you were getting the same errors with out resetting then that suggests it's not part of the problem, though it begs the question why mrkgnao started seeing issues after doing it at work...

Back up your sort order first and if you wouldn't mind trying it and seeing what happens for you that would be great.

[...]
Sorry, haven't followed this too closely - are markgnao's errors different from the ones I reported earlier today?
Note please that I'm on "All" when not doing tests, and even then I don't recall pages showing in the wrong order.



avatar
mrkgnao: But you did use import. Perhaps import does reset internally before importing?
Truth is that I imported my initial manually sorted order from SWare Iron to Firefox. But I've moved a number of games on Firefox after that, using both the "Move" feature, as well drag & scroll via Firefox add-on). Not sure if this is of importance.
Posted January 05, 2016
high rated
avatar
adaliabooks: I don't suppose there's some kind of test account I could use with access to the full library (minus the ability to download obviously) so I might actually be able to find a see these errors myself?
No, there's not. Maybe try to lower games per page in your script to fit your library and try to reproduce then? Don't know if that's possible. Or - insert console.log here and there, give it to someone and get the output.
Post edited January 05, 2016 by Johny.
Posted January 05, 2016
high rated
avatar
HypersomniacLive: Sorry, haven't followed this too closely - are markgnao's errors different from the ones I reported earlier today?
Note please that I'm on "All" when not doing tests, and even then I don't recall pages showing in the wrong order.
As far as I can tell most people have the page's missing due to duplicate games error, but mrkgnao has also got issues with games in the wrong places which may or may not be related..

I'm not sure that importing or resetting has any effect or not yet, though they are similar they are nit identical in their workings..
avatar
Johny.: No, there's not. Maybe try to lower games per page in your script to fit your library and try to reproduce then? Don't know if that's possible. Or - insert console.log here and there, give it to someone and get the output.
Didn't think so...
I've tried that but wasn't getting any errors.
Yeah, I think I'll just have to scatter a lot of debug calls through the script and update and get some logs to see if I can spot discrepancies.
Thanks :)
Post edited January 05, 2016 by adaliabooks
Posted January 05, 2016
high rated
avatar
adaliabooks: No errors for me in either Chrome or Firefox while resetting, changing options, changing pages... Presumably quantity of games must have something to do with it (moon hasn't reported any troubles and she said she had about 300 and something) as those with larger libraries seem to get it more / worse..
I just tried it after seeing this :D

And I am sorry, but I have to report I am also getting empty pages after the first one when setting the library to 100 games per page. I just never noticed since I was using the "show all" option all the time.
Posted January 05, 2016
high rated
avatar
moonshineshadow: I just tried it after seeing this :D

And I am sorry, but I have to report I am also getting empty pages after the first one when setting the library to 100 games per page. I just never noticed since I was using the "show all" option all the time.
Thanks moon :)
So library size doesn't seem to be an issue... yet I still am not seeing the bug myself.

Is it only an issue on 100 or any setting other than All?
Posted January 05, 2016
high rated
avatar
adaliabooks: Is it only an issue on 100 or any setting other than All?
Oh that is quite fun when setting it to 200 games....
I see 100 games on the first page and an empty second page :D

Same happens with 300 games per page.
Post edited January 05, 2016 by moonshineshadow
Posted January 05, 2016
high rated
avatar
adaliabooks: Is it only an issue on 100 or any setting other than All?
avatar
moonshineshadow: Oh that is quite fun when setting it to 200 games....
I see 100 games on the first page and an empty second page :D

Same happens with 300 games per page.
Hmmm
Well, that definitely narrows down the issue to my slicing code, though I can't for the life of me see what is actually wrong with it.

On 200 games per page could you run the first command I asked foxworks and mrkgnao to do earlier (a few pages back now I think) and put the output somewhere for me?
I'm curious to why it's only showing 100 games...
Posted January 05, 2016
high rated
avatar
adaliabooks: On 200 games per page could you run the first command I asked foxworks and mrkgnao to do earlier (a few pages back now I think) and put the output somewhere for me?
I'm curious to why it's only showing 100 games...
I attached the output, just download it and change the file to .txt :-)
Attachments:
first_command.jpg (133 Kb)
Posted January 05, 2016
avatar
adaliabooks: On 200 games per page could you run the first command I asked foxworks and mrkgnao to do earlier (a few pages back now I think) and put the output somewhere for me?
I'm curious to why it's only showing 100 games...
avatar
moonshineshadow: I attached the output, just download it and change the file to .txt :-)
Thanks moon.
Posted January 05, 2016
high rated
avatar
adaliabooks: On 200 games per page could you run the first command I asked foxworks and mrkgnao to do earlier (a few pages back now I think) and put the output somewhere for me?
I'm curious to why it's only showing 100 games...
avatar
moonshineshadow: I attached the output, just download it and change the file to .txt :-)
Well... that's not at all what I expected. The output you've provided shows it working exactly as it should; two pages with a hundred games and no duplicates.
And if I load it into my library it works (though most of the covers don't show as I don't own them).
Which begs the question; why isn't the second page showing for you?

Do you get an error on that page?
If you set it to 200 and refresh does it happen, or is it happening if you just change from another setting to 200?

And the other question is why does it work fine on 'All', because it's basically the same implementation...
Unless.... *goes off to check code*
Posted January 05, 2016
high rated
avatar
adaliabooks: Do you get an error on that page?
If you set it to 200 and refresh does it happen, or is it happening if you just change from another setting to 200?
If I set it to 200 and refresh the page, the 200 games show. But I really need to do a refresh, while when setting it to "show all games" it works without a refresh.

This is the error I get when changing the setting before doing a refresh:

"Error: [ngRepeat:dupes] Duplicates in a repeater are not allowed. Use 'track by' expression to specify unique keys. Repeater: product in productPage.products track by product.id, Duplicate key: 1207659064, Duplicate value: {"isGalaxyCompatible":true,"tags":[],"id":1207659064,"availability":{"isAvailable":true,"isAvailableInAccount" :true},"title":"Sam & Max Beyond Time and Space","image":"//images-4.gog.com/68041749125af1dede8a12073c0509331b264fb08dacd4a9c312578535cdf614","url":"/g ame/sam_max_beyond_time_and_space","worksOn":{"Windows":true,"Mac":false,"Linux":false},"category":"Adventure" ,"rating":44,"isComingSoon":false,"isMovie":false,"isGame":true,"slug":"sam_max_beyond_time_and_space","update s":0,"isNew":false,"dlcCount":0,"releaseDate":{"date":"2007-11-09 00:00:00","timezone_type":3,"timezone":"Europe/Nicosia"},"isBaseProductMissing":false,"isHidingDisabled":false ,"isHidden":false}
http://errors.angularjs.org/1.4.3/ngRepeat/dupes?p0=product%20in%20productPage.products%20track%20by%20product.id&p1=1207659064&p2=%7B%22isGalaxyCompatible%22%3Atrue%2C%22tags%22%3A%5B%5D%2C%22id%22%3A1207659064%2C%22availability%22%3A%7B%22isAvailable%22%3Atrue%2C%22isAvailableInAccount%22%3Atrue%7D%2C%22title%22%3A%22Sam%20%26%20Max%20Beyond%20Time%20and%20Space%22%2C%22image%22%3A%22%2F%2Fimages-4.gog.com%2F68041749125af1dede8a12073c0509331b264fb08dacd4a9c312578535cdf614%22%2C%22url%22%3A%22%2Fgame%2Fsam_max_beyond_time_and_space%22%2C%22worksOn%22%3A%7B%22Windows%22%3Atrue%2C%22Mac%22%3Afalse%2C%22Linux%22%3Afalse%7D%2C%22category%22%3A%22Adventure%22%2C%22rating%22%3A44%2C%22isComingSoon%22%3Afalse%2C%22isMovie%22%3Afalse%2C%22isGame%22%3Atrue%2C%22slug%22%3A%22sam_max_beyond_time_and_space%22%2C%22updates%22%3A0%2C%22isNew%22%3Afalse%2C%22dlcCount%22%3A0%2C%22releaseDate%22%3A%7B%22date%22%3A%222007-11-09%2000%3A00%3A00%22%2C%22timezone_type%22%3A3%2C%22timezone%22%3A%22Europe%2FNicosia%22%7D%2C%22isBaseProductMissing%22%3Afalse%2C%22isHidingDisabled%22%3Afalse%2C%22isHidden%22%3Afalse%7D
d/<@[url=https://www4-static4.gog.com/js/c1a69ab-ce05db4.js:6:381]https://www4-static4.gog.com/js/c1a69ab-ce05db4.js:6:381[/url]
ig</<.compile/</<@[url=https://www4-static4.gog.com/js/c1a69ab-ce05db4.js:10:18683]https://www4-static4.gog.com/js/c1a69ab-ce05db4.js:10:18683[/url]
d@[url=https://www4-static4.gog.com/js/c1a69ab-ce05db4.js:8:4145]https://www4-static4.gog.com/js/c1a69ab-ce05db4.js:8:4145[/url]
pc/this.$get</n.prototype.$digest@[url=https://www4-static4.gog.com/js/c1a69ab-ce05db4.js:8:4872]https://www4-static4.gog.com/js/c1a69ab-ce05db4.js:8:4872[/url]
pc/this.$get</n.prototype.$apply@[url=https://www4-static4.gog.com/js/c1a69ab-ce05db4.js:8:6433]https://www4-static4.gog.com/js/c1a69ab-ce05db4.js:8:6433[/url]
f@[url=https://www4-static4.gog.com/js/c1a69ab-ce05db4.js:7:13108]https://www4-static4.gog.com/js/c1a69ab-ce05db4.js:7:13108[/url]
r@[url=https://www4-static4.gog.com/js/c1a69ab-ce05db4.js:7:14907]https://www4-static4.gog.com/js/c1a69ab-ce05db4.js:7:14907[/url]
Cb/</v.onload@[url=https://www4-static4.gog.com/js/c1a69ab-ce05db4.js:7:15447]https://www4-static4.gog.com/js/c1a69ab-ce05db4.js:7:15447[/url]
Pages:
1
50
54
55
56
57
58
150
200
240
This is my favourite topic
Community
General discussionAdalia Fundamentals - Fixing GoG so you don't have to!(3599 posts)(3599 posts)
(3599 posts)