It seems that you're using an outdated browser. Some things may not work as they should (or don't work at all).
We suggest you upgrade newer and better browser like: Chrome, Firefox, Internet Explorer or Opera

×
high rated
avatar
adaliabooks: I wonder if it's possible to recreate the function somehow if the browser doesn't support it?
avatar
geminidomino: That's what I'm playing with now. I know cloneInto was a new API in Fx 29, so I'm trying to figure out how the same thing was done before then (since IIRC, Palemoon was forked from Firefox 24 or 25)
This article might help, goes into the basics of cloneInto and stuff.

Looking around there do seem to be a few issues with cloneInto in Palemoon, but hopefully a workaround of some sort can be sorted out.
high rated
I found one on StackOverflow. It's an ugly hack, but I've tested it and it works.

I don't know if you want to deal with anything this klugy, since I'm the only one who had the problem, and we still dunno why... but if you're interested, here's a not-a-diff diff :)

http://pastebin.com/kwfcaPzT

The Review code doesn't seem to like that much, but it doesn't kill the script anymore.

Once more into the breach!

Derp. Just a fat-finger. Reviews work too (replaced pastebin link)
Post edited December 23, 2015 by geminidomino
high rated
avatar
geminidomino: I found one on StackOverflow. It's an ugly hack, but I've tested it and it works.

I don't know if you want to deal with anything this klugy, since I'm the only one who had the problem, and we still dunno why... but if you're interested, here's a not-a-diff diff :)

http://pastebin.com/kwfcaPzT

The Review code doesn't seem to like that much, but it doesn't kill the script anymore.

Once more into the breach!

Derp. Just a fat-finger. Reviews work too (replaced pastebin link)
Nice job :)

I maybe won't include it into the script, but I'll add a note in the OP about Palemoon and link to your post and fix and people can perhaps add it themselves..

I'll see though, because if I'm using 'it's a bit hacky' as a reason not to include it I'd probably have to cut out half the script XD
high rated
Another problem solved by trained professionals!
high rated
avatar
geminidomino: Another problem solved by untrained amateurs!
FTFY! (in my case anyway)
high rated
Right.

I'm not quite ready to push the update yet (there are still some niggling little bugs that I can hopefully iron out) but Manual Sort (with draggable games and everything) is almost done.

I'll probably add some other methods to rearrange things (currently you can only drag within the visible window because it won't scroll while dragging and I can't find a way to make it) so moving something from the top to the bottom (or vice versa) would take a while.
I'll also add options to reset the list (basically sort alphabetically or by purchase date etc.), to import and export it (one of the current niggling bugs is a tendency to delete any changes and revert the sorting order when there is another error, which is obviously no good and one of the reasons I'm not pushing an update just yet) and possibly some other things.

Anyway, I'm really hoping to get it sorted tomorrow and have it ready in time for Christmas, as my little gift to everyone :)

Further details to come!
high rated
avatar
adaliabooks: Anyway, I'm really hoping to get it sorted tomorrow and have it ready in time for Christmas, as my little gift to everyone :)
That would be awesome. But don't stress yourself if it does not work out :-)
high rated
avatar
adaliabooks: [...]

Anyway, I'm really hoping to get it sorted tomorrow and have it ready in time for Christmas, as my little gift to everyone :)

Further details to come!
W00T!!

*prepares wrapping paper and bow*


Would also make a lovely New Year's present, so take your time and enjoy the season.
high rated
Update is here.

We have manual sort! :)
I'd call this a beta at the moment, just to see if things are working on everyone else's configurations. It's not 100% there yet, but I was determined to have something up before Christmas :)

So, it's a little bare bones at the moment, and there are still some bugs. If manual sorting is on in the menu then you can drag and drop your games to move them around (whatever sorting you currently have set is saved as your base manual sort when you first enable it, I'll put some options to clear the sorting and reset to a default sort by title etc. in the future)

Main issue is sometimes the games don't swap immediately.. I'm not sure why yet, still playing around. Sometimes wait a few seconds and it will do it, other times you need to refresh the page. If the swap is successful after a few seconds this can disable the dragging and you need to refresh. I'm working to fix that, but haven't found a satisfactory solution yet.
Either way the sorting order always seems to update all right, and you can keep moving games even if they don't swap (though keep in mind that it's the games themselves that are important, not their position. Even if the swap isn't visible. If you move Game A to before Game B but it doesn't visually change, then you move Game C to before Game A [still in it's old position] then you will end up with C, A, B)
This happens more in Firefox, for no reason that is yet apparent.

But as far as I can tell the sorting is sticking and not being reset or deleted when there are bugs (which was a problem I did have in original implementations) and I'm not getting any actual errors from anything. Though this may not be the case for everyone, which is part of the reason for putting this out there to test.

Let me know what you think :)
high rated
avatar
adaliabooks: Update is here.

We have manual sort! :)
I'd call this a beta at the moment, just to see if things are working on everyone else's configurations. It's not 100% there yet, but I was determined to have something up before Christmas :)
Great work. Thanks.

Now to the bad news ;-)

I just made a quick test and for me I always need to refresh to see any change at all and sometimes it does not change the order of games but instead shows me again the bug with the messed up sorting (the one where the first page shows then the last page etc.). When I refresh again, the sorting bug is gone again. And sometimes even after a refresh when I try to drag a game nothing happens. The order of games does not change even after a refresh.
But the console is not showing me any errors.
high rated
avatar
adaliabooks:
Began by testing what had bugged me most: the malfunctioning wishlist. Glad to report that this is resolved.
Cheers!
high rated
avatar
adaliabooks:
Wow!
Your manual sort also works in list mode!
I don't think that was ever the case for GOG's manual mode!
Impressive!

And it's pretty much as you describe. Sometimes it swaps, sometimes it doesn't, but on reload it looks ok.
Don't expect to use it, but glad others will be able to.
high rated
avatar
moonshineshadow: Great work. Thanks.

Now to the bad news ;-)

I just made a quick test and for me I always need to refresh to see any change at all and sometimes it does not change the order of games but instead shows me again the bug with the messed up sorting (the one where the first page shows then the last page etc.). When I refresh again, the sorting bug is gone again. And sometimes even after a refresh when I try to drag a game nothing happens. The order of games does not change even after a refresh.
But the console is not showing me any errors.
Not sure about the sorting bug thing, that really shouldn't happen at all with the way the manual sorting works.
When you get that are the games manually sorted or whatever gog sort you have set?

Right, it definitely needs tightening up then. For me the bugs have been more of a minor hindrance, a little more annoying on Firefox than Chrome, but what you're describing is worse.

It's to do with the timings and things of the function calls. Some of them fire before the things they are supposed to act upon are actually ready and so fail (which is why the dragging doesn't always work) but while I can see why with some bits I can't figure out what the delay is in others.
avatar
mrkgnao: Began by testing what had bugged me most: the malfunctioning wishlist. Glad to report that this is resolved.
Cheers!
That was easy to sort, just a matter of applying changes to library pages only.
avatar
mrkgnao: Wow!
Your manual sort also works in list mode!
I don't think that was ever the case for GOG's manual mode!
Impressive!

And it's pretty much as you describe. Sometimes it swaps, sometimes it doesn't, but on reload it looks ok.
Don't expect to use it, but glad others will be able to.
Happy accident that XD

Thanks, so you're not getting by bugs as badly as moon then..
How many games per page were you displaying when you tried?
Post edited December 25, 2015 by adaliabooks
avatar
adaliabooks: Thanks, so you're not getting by bugs as badly as moon then..
How many games per page were you displaying when you tried?
100.
Bookmarked. Another useful topic. Thanks adaliabooks.