It seems that you're using an outdated browser. Some things may not work as they should (or don't work at all).
We suggest you upgrade newer and better browser like: Chrome, Firefox, Internet Explorer or Opera

×
Community
General discussionAdalia Fundamentals - Fixing GoG so you don't have to!(3599 posts)(3599 posts)
(3599 posts)
Pages:
1
32
33
34
35
36
50
100
150
200
240
This is my favourite topic
Posted December 21, 2015
high rated
Cheers for all your hard work on what is now a GOG staple :)
Posted December 21, 2015
high rated
avatar
moonshineshadow: If I write it like this:

libraryScope.getLegacyUrl = function (id)
{
return ("http://static04.gog.com/upload/images/2014/02/9a5c557e581a852723ec90084fdac6992754a2de.jpg");
}

The menu re-appears, but the library images are just blanks, but without images I can load all games in legacy view without Firefox freezing :D
Thanks :)

If you take out the brackets but leave the quotes (that's what I get for rushing when I did it) it should work as intended, and see if the image displays and the library still loads then I can tell whether it is the sheer weight of images or something to do with that function that's the problem.
avatar
foxworks: Cheers for all your hard work on what is now a GOG staple :)
No problem :)
Frustrating as it can be, I really enjoy it. And it's nice to know I'm doing something that helps other people :)
Post edited December 21, 2015 by adaliabooks
Posted December 21, 2015
high rated
avatar
moonshineshadow: The menu re-appears, but the library images are just blanks, but without images I can load all games in legacy view without Firefox freezing :D
avatar
adaliabooks: Thanks :)

If you take out the brackets but leave the quotes (that's what I get for rushing when I did it) it should work as intended, and see if the image displays and the library still loads then I can tell whether it is the sheer weight of images or something to do with that function that's the problem.
I already tried that, taking out the brackets does not change anything. I get the legacy view without any images.
Posted December 21, 2015
high rated
avatar
adaliabooks: Thanks :)

If you take out the brackets but leave the quotes (that's what I get for rushing when I did it) it should work as intended, and see if the image displays and the library still loads then I can tell whether it is the sheer weight of images or something to do with that function that's the problem.
avatar
moonshineshadow: I already tried that, taking out the brackets does not change anything. I get the legacy view without any images.
Hmmm. Maybe it's the url then. It should probably not include the https and gog.com bits..
Not doing this very well XD
Posted December 21, 2015
high rated
Gotcha!

Well.. that was a bug and a half.

It turns out the issue was (still) with the reporting missing art section, but this time for an entirely different reason.

I shifted the code that gets the url into a function that's called when the url is needed which saved me having to figure out when a page was changed and reassigning every url each time.
But it also meant that the AJAX call to report a missing box was called every time the function was called, which thinking about it is probably every time angular runs any kind of refresh or something (clearly it was a lot anyway).

I racked up 2500+ AJAX calls, which would be why everyone's browsers were crashing.

For now I've commented out the actual reporting mechanism to see if that cures the issue for everyone and I'll work on an alternative solution.
Posted December 21, 2015
high rated
avatar
adaliabooks: For now I've commented out the actual reporting mechanism to see if that cures the issue for everyone and I'll work on an alternative solution.
It is working and I have all my games on one page without any crashes or freezing :D

Only pictures that are missing: Card City Nights and Never Alone Arctic Collection.
Post edited December 21, 2015 by moonshineshadow
Posted December 21, 2015
high rated
avatar
adaliabooks: For now I've commented out the actual reporting mechanism to see if that cures the issue for everyone and I'll work on an alternative solution.
avatar
moonshineshadow: It is working and I have all my games on one page without any crashes or freezing :D

Only pictures that are missing: Card City Nights and Never Alone Arctic Collection.
Excellent :)

Yeah, I'll rework the automatic system and the missing ones should be fixed soon after.

Is the sorting order thing still a problem? If so, is it only the last page that is in the wrong place, or are they all off?
Posted December 21, 2015
high rated
Yeah! Works as intended with "All" and "Purchase Date".

Hope you find an alternative solution soon, and without much effort.
Posted December 21, 2015
high rated
avatar
HypersomniacLive: Yeah! Works as intended with "All" and "Purchase Date".

Hope you find an alternative solution soon, and without much effort.
It shouldn't be a problem really, just need to log which ids have already been reported each round (so it would resend them if you refreshed your account or visited it again, but not multiple times within the same session) and then I'll have the script on my server fetching the new ones run once or twice a day to fetch missing images.

The only thing I might need to do manually is art for bundled games, as there's no way to match the ID to the parent game whose art I could use. But perhaps mrkgnao has a way to associate the ids of bundled games to their catalogue parent, or even just a way I can do it through MaGoG so I can manually fix those occasionally.


I think I've fixed the sorting, the pages weren't actually sorting at all so the last page was loading first and appearing before the others. It should work now though (with the next little update)
avatar
mrkgnao: snip
avatar
foxworks: snip
As you both have a large library, would either of you try the latest update and see if it works and loads without too much slowdown?

Thanks :)
Post edited December 21, 2015 by adaliabooks
Posted December 21, 2015
high rated
avatar
adaliabooks: Is the sorting order thing still a problem? If so, is it only the last page that is in the wrong place, or are they all off?
Sorting is still wrong for me. The last page appears after the first page, then comes the second and then the third page.
Posted December 21, 2015
high rated
avatar
adaliabooks: Is the sorting order thing still a problem? If so, is it only the last page that is in the wrong place, or are they all off?
avatar
moonshineshadow: Sorting is still wrong for me. The last page appears after the first page, then comes the second and then the third page.
Thanks moon, I think I've got it now :)
Posted December 21, 2015
high rated
You can add Bio Menace to the games without a box cover.

On the good news side - the update dots are also working again.
Post edited December 21, 2015 by HypersomniacLive
Posted December 21, 2015
high rated
avatar
HypersomniacLive: You can add Bio Menace to the games without a box cover.

On the good news side - the update dots are also working again.
Oh. That's nice :)
One less thing to fix.

I'll get it once the auto report is working :)
Posted December 21, 2015
high rated
Report:

Tried "All" with my library (1219), using "Legacy Wood". Seems to work fine. Good show!

However...

The order of the games, which should have been by title, is incorrect in this case. Within a 100-game "sub-page" the order is correct, but the order of "sub-pages" is incorrect. It is something like: page 1, page 7, page 5, page 2, etc.. Resulting in an order that look A,B, L, M, G, etc.

I have seen something very similar before, when Barefoot updated his wiki library BE code. I reported it . You might want to ask Barefoot. Or you could ask this guy called adaliabooks, who seemed to know something about it [url=https://www.gog.com/forum/general/barefoot_essentials_2_gogcom_enhancement/post710]here.
Post edited December 21, 2015 by mrkgnao
Posted December 21, 2015
high rated
avatar
adaliabooks: Oh. That's nice :)
One less thing to fix.

I'll get it once the auto report is working :)
Don't mean to be pushy, but I hope you haven't forgotten about adding a "New" tag. :-)
Pages:
1
32
33
34
35
36
50
100
150
200
240
This is my favourite topic
Community
General discussionAdalia Fundamentals - Fixing GoG so you don't have to!(3599 posts)(3599 posts)
(3599 posts)