HypersomniacLive: Two things:
I've completely disabled NoScript, and updated AF - still getting the same result.
When stuck with the default GOG style (your site disallowed), the Downloader button is (obviously?) not there, yet the related errors are in the console.
And I just updated AF in my SWare Iron browser, where I have only BE and AF installed (using TamperMonkey), and guess what? No Legacy shelf, just the default GOG one.
I was going to check if any of my other Firefox add-ons get in the way, but since I have the same problem on my other browser, I'm not sure it's worth the trouble.
Ok. If my site is disallowed none of the account options would load at all (probably) because they are wrapped in a done() based on the AJAX call, so if it fails none of the other functions get called... so I've changed that to an always so if my site is blocked it should only stop the covers from showing.
Not sure why the error still occurs. Maybe it's actually a GoG error and nothing to do with me...
Yeah, if a bare browser with no add ons does it then I wouldn't worry about checking individual add-ons.
plagren: I don't know if I'm having the same exact problem as HypersomniacLive, but... The library only seems to show up for me if the sort order is set to either "title" or "oldest first" when the page is initially loaded. After that I can change the sorting to something else without issues - but if I refresh the page, the library disappears.
I'm kind of guessing these issues actually have more to do with the gamesPerPage option rather than the new cover's implementation... but I'm not sure.
HypersomniacLive: The only reason I mentioned it is because now it seems to load the whole library in the default GOG style before switching to the Legacy one, up until the previous version of AF, the switch was almost instant, as was loading my Library in that style.
This is related to the fact the functions are all wrapped in the return function if the AJAX, so they all wait for that to happen before continuing. Unfortunately that means there is a slight delay, but it's the easiest way I can see to make sure the list of Urls is there when it's required.
Which may be why some of the sorting options fail to load too... the wait and allowing the page to fully load before my script stuff kicks in may cause trouble...
The mismatched shelf colours are an old, as yet unfixed, issue from the games per page stuff.
I think the main issue here is to find a more robust solution for the extra games as I have a feeling that's the main cause of the problems...
But, to test this, can you guys try disabling the gamesPerPage functions by commenting out lines 2845 and 2846 and see what happens? (add // to the start of the lines if you don't know how to comment out)
That should stop more than 100 games showing per page but it may also stop the other issues and at least I know what needs work then.
Thanks for all your help and testing guys :)