It seems that you're using an outdated browser. Some things may not work as they should (or don't work at all).
We suggest you upgrade newer and better browser like: Chrome, Firefox, Internet Explorer or Opera

×
high rated
I don't know if I'm having the same exact problem as HypersomniacLive, but... The library only seems to show up for me if the sort order is set to either "title" or "oldest first" when the page is initially loaded. After that I can change the sorting to something else without issues - but if I refresh the page, the library disappears.
avatar
plagren: I don't know if I'm having the same exact problem as HypersomniacLive, but... The library only seems to show up for me if the sort order is set to either "title" or "oldest first" when the page is initially loaded. After that I can change the sorting to something else without issues - but if I refresh the page, the library disappears.
Ha, let me check and see how that behaves for me.
high rated
OK, here are my findings:

Every time I open my Library page, the default GOG style loads first, then it changes to the Legacy one. May be related to my setting being "All" and having over 500 titles.


(A) Change "Sort By" to "Title", close and reopen Library.
At first it loaded the default GOG style, then loaded the Legacy style, but only the first 20 shelves, i.e. he first 100 games.
I refreshed the page (from the browser's refresh button), and it loaded my whole Library, but with the interesting side-effect you can see in the first two attachments. Note that the change from "Dark" to "Wood" happens at the 21st shelf, i.e. after the first 100 games. Coincidence? I don't know.

(B) Change "Sort By" to "Oldest First", refresh Library page.
The whole Library loads, but with a side effect as can be seen in the third and second attachment. Refreshing the page again leads to the first 20 shelves having the "Dark" background, the rest having the "Wood" one. Closing and reopening my Library page has the same result as a second refresh of the page.

(C) Change "Sort By" to "Newest First", refresh Library page.
Same as (B).

(D) Change "Sort By" to "Purchase Date", refresh page.
The whole Library loads with the side effect of the "Dark" & "Wood" shelves/background. Refreshing the page again leads to what I show you in my post #415. Same with closing and reopening my Library page.

It seems that there's something conflicting with the "Purchase Date" sorting option.
Hope this helps pin-point and fix the issue.


And since I was able to get a look at my whole Library, the titles missing art covers are:

- Divinity: Original Sin - Enhanced Edition
- Legends of Eisenwald
- Pathologic Classic HD
- The Moment of Silence
- Wasteland 2 Director's Cut



@mrkgnao
Which settings are you using? If you're on "Title" and "Wood" t might explain why you're not having an issues. Could you please try any other combos and report back?
Attachments:
avatar
HypersomniacLive: OK, here are my findings:

Every time I open my Library page, the default GOG style loads first, then it changes to the Legacy one. May be related to my setting being "All" and having over 500 titles.
Same here. And I use the default 100. Didn't bother me, to tell the truth, which is why I didn't mention it before.

avatar
HypersomniacLive: @mrkgnao
Which settings are you using? If you're on "Title" and "Wood" t might explain why you're not having an issues. Could you please try any other combos and report back?
I indeed use Title and Wood. If I change, I too get all the issues that you have reported.
high rated
avatar
mrkgnao: Same here. And I use the default 100. Didn't bother me, to tell the truth, which is why I didn't mention it before.

[...]
The only reason I mentioned it is because now it seems to load the whole library in the default GOG style before switching to the Legacy one, up until the previous version of AF, the switch was almost instant, as was loading my Library in that style.


avatar
mrkgnao: [...]

I indeed use Title and Wood. If I change, I too get all the issues that you have reported.
Cheers, relieved to hear it, would hate to be the odd one out, again.
high rated
avatar
HypersomniacLive: Two things:

I've completely disabled NoScript, and updated AF - still getting the same result.
When stuck with the default GOG style (your site disallowed), the Downloader button is (obviously?) not there, yet the related errors are in the console.

And I just updated AF in my SWare Iron browser, where I have only BE and AF installed (using TamperMonkey), and guess what? No Legacy shelf, just the default GOG one.

I was going to check if any of my other Firefox add-ons get in the way, but since I have the same problem on my other browser, I'm not sure it's worth the trouble.
Ok. If my site is disallowed none of the account options would load at all (probably) because they are wrapped in a done() based on the AJAX call, so if it fails none of the other functions get called... so I've changed that to an always so if my site is blocked it should only stop the covers from showing.
Not sure why the error still occurs. Maybe it's actually a GoG error and nothing to do with me...

Yeah, if a bare browser with no add ons does it then I wouldn't worry about checking individual add-ons.

avatar
plagren: I don't know if I'm having the same exact problem as HypersomniacLive, but... The library only seems to show up for me if the sort order is set to either "title" or "oldest first" when the page is initially loaded. After that I can change the sorting to something else without issues - but if I refresh the page, the library disappears.
I'm kind of guessing these issues actually have more to do with the gamesPerPage option rather than the new cover's implementation... but I'm not sure.

avatar
HypersomniacLive: The only reason I mentioned it is because now it seems to load the whole library in the default GOG style before switching to the Legacy one, up until the previous version of AF, the switch was almost instant, as was loading my Library in that style.
This is related to the fact the functions are all wrapped in the return function if the AJAX, so they all wait for that to happen before continuing. Unfortunately that means there is a slight delay, but it's the easiest way I can see to make sure the list of Urls is there when it's required.
Which may be why some of the sorting options fail to load too... the wait and allowing the page to fully load before my script stuff kicks in may cause trouble...

The mismatched shelf colours are an old, as yet unfixed, issue from the games per page stuff.

I think the main issue here is to find a more robust solution for the extra games as I have a feeling that's the main cause of the problems...

But, to test this, can you guys try disabling the gamesPerPage functions by commenting out lines 2845 and 2846 and see what happens? (add // to the start of the lines if you don't know how to comment out)
That should stop more than 100 games showing per page but it may also stop the other issues and at least I know what needs work then.

Thanks for all your help and testing guys :)
high rated
avatar
adaliabooks: [...]

I'm kind of guessing these issues actually have more to do with the gamesPerPage option rather than the new cover's implementation... but I'm not sure.

[...]

I think the main issue here is to find a more robust solution for the extra games as I have a feeling that's the main cause of the problems...

But, to test this, can you guys try disabling the gamesPerPage functions by commenting out lines 2845 and 2846 and see what happens? (add // to the start of the lines if you don't know how to comment out)
That should stop more than 100 games showing per page but it may also stop the other issues and at least I know what needs work then.

[...]
Sorry, no dice. Even after disabling the gamesPerPage functions, the results are identical - see attached screenshot when "Sort By" is set to "Purchase Date".


avatar
adaliabooks: [...]

Which may be why some of the sorting options fail to load too... the wait and allowing the page to fully load before my script stuff kicks in may cause trouble...

[...])
The only sorting option that fails to load is the "Purchase Date" (can't test the one for tags, as I don't use tags at all), at least in my case.


avatar
adaliabooks: [...]

Thanks for all your help and testing guys :)
You're welcome, and thanks back!
Attachments:
No matter what I do I can't see my library. It briefly shows up when I refresh the page but then it disappears, not sure what to do.
high rated
avatar
trentonlf: No matter what I do I can't see my library. It briefly shows up when I refresh the page but then it disappears, not sure what to do.
What browser are you on trent? Chrome or Firefox?

I think we might just need to rollback to the last version for now and I'll keep working on it. Clearly there is something not quite right going on.
avatar
HypersomniacLive: Sorry, no dice. Even after disabling the gamesPerPage functions, the results are identical - see attached screenshot when "Sort By" is set to "Purchase Date".

The only sorting option that fails to load is the "Purchase Date" (can't test the one for tags, as I don't use tags at all), at least in my case.
Hmmm..

So is it only some of the shelf style options that aren't working? I thought you said Legacy was working earlier..

Not sure why the Purchase Date load would fail, particularly with the gamesPerPage stuff disabled...
Post edited December 18, 2015 by adaliabooks
avatar
adaliabooks: What browser are you on trent? Chrome or Firefox?
..
Chrome
high rated
avatar
adaliabooks: What browser are you on trent? Chrome or Firefox?
..
avatar
trentonlf: Chrome
That's what I thought.
Well that is odd then... the problems mostly usually occur in Firefox.

I'm thinking (as I have no issues) the problems may be somewhat related to number of games too... though I'm not sure why that may be an issue if the games per pages options are off... but perhaps more games means the library takes that much longer to load and that delay between the proper load and my scripts kicking in causes the problem.

So I need to find a better way to load the url info that doesn't need to stop the rest of the functions running....
avatar
adaliabooks: That's what I thought.
Well that is odd then... the problems mostly usually occur in Firefox.

I'm thinking (as I have no issues) the problems may be somewhat related to number of games too... though I'm not sure why that may be an issue if the games per pages options are off... but perhaps more games means the library takes that much longer to load and that delay between the proper load and my scripts kicking in causes the problem.

So I need to find a better way to load the url info that doesn't need to stop the rest of the functions running....
I only have 349 games
high rated
avatar
trentonlf: I only have 349 games
Still three times more than me, that may be enough to be a problem (or it's something completely different).

I've got a quick update which might solve some of the problems, or at least let me know what the issues are.

Just uploading it now.
high rated
avatar
adaliabooks: [...]
Hmmm..

So is it only some of the shelf style options that aren't working? I thought you said Legacy was working earlier..

Not sure why the Purchase Date load would fail, particularly with the gamesPerPage stuff disabled...
OK, let's try this one more time.

I've disabled the gamesPerPage functions. Everything still behaved the way I described in my post #423.
Since the Library is not loading at all when "Sort By" is set to "Purchase Date", and you hoped that disabling those functions may had solve the problem, I included a screenshot of that particular case to show you that the problem is probably not related to them.

I hope it's clearer now. If it's not - have you been drinking, again? ;-P
high rated
Right, I've updated (just moved the AJAX call to the top of the script, seems to work for me alright but lets just see if it has any effect on the issues everyone else is having)


I am wondering if GoG may have just changed something and broken it.. I noticed the update flags seem to have stopped showing, will have to look into that one, and it may just be they are making changes in the account section...
avatar
HypersomniacLive: OK, let's try this one more time.

I've disabled the gamesPerPage functions. Everything still behaved the way I described in my post #423.
Since the Library is not loading at all when "Sort By" is set to "Purchase Date", and you hoped that disabling those functions may had solve the problem, I included a screenshot of that particular case to show you that the problem is probably not related to them.

I hope it's clearer now. If it's not - have you been drinking, again? ;-P
Sorry, I thought you'd said earlier that the shelf styles were a problem, but maybe I misunderstood and it was the sorting you meant...

No drinking today :P

Can you try it again with the latest update and just see if that has any effect at all?
Post edited December 19, 2015 by adaliabooks