Slight delay with the games per page option.
The original load works fine, but when you change any options it doesn't work and I can't quite see why yet...
Something to do with the AJAX calls in the loop all returning the same result, but I don't see why that should be the case...

And then I think there are some Firefox issues too, but I'll sort those once I've got the basic implementation working in Chrome.

I'll get there!

Right, issues sorted. New update is here, and we have customisable library size!

The option is just in the Fundamentals menu for now, I couldn't find room to put a dropdown on the account page as it's quite cluttered already and I figured most people are probably happy sticking with one page size.

I'm expecting there might be some problems, though I've tried to cover all the bases this time. The only bug I kind of know exists is if you change your sorting settings too quickly it can break it, but a refresh will sort it out.

I've also fixed the update notifications with a blue spot in the corner of the legacy and remix styles.

And plagren has tweaked the shelf styles some more which I've added too.

As usual, let me know if there are any issues.

Enjoy!

Nice! Good work! +many!

Set it to "all" and loaded the library. Managed to see it in it all its glory for a second or so before Firefox crashed. Tried with both "list" and "grid" mode, with much the same result (grid crashed faster).

I guess I have too many games (1174) and GOG's code is just too bloated. Returned to "100".

No big deal. I'm not using the library at all anymore and MaGog has no problem displaying 1336 games with a lot more information per game, so I'm good.

XD

I think now we know why GoG stuck with 100 per page then...

Hmmm, if it's crashing Firefox (as in completely out of the program?) then I can only imagine it can't take the strain of loading all the games at once into angular's ng-repeat...

I'll have a look around and see if there's any limits mentioned anywhere about what it might be able to cope with and if there are any work arounds...

Would you mind checking how many games it can load successfully? If it's going to crash out even at 200 or 300 it might not be worth bothering with...

Nice, nice, nice! I have 534 games, and setting it to "All" worked just fine. I think we can safely assume that up to 550-600 won't crash Firefox.

I suspect that the crashing point may be the 1,000 mark, but can't test it for obvious reasons.


Regarding plagren's tweaked style - is it just me or is the font even brighter now?

Well, that's not too bad then. If it can manage that much at least that's something.

Yeah, it's a tough one to test...

You'd have to ask him, I've just been adding whatever he's done...

Eek. I'm often getting the wrong shelf background (and missing the "show hidden games" option) when the shelf is refreshed (while searching, changing pages etc.)

Since the last version? Hmm, shouldn't be...

Will it also add games that Gog are too lazy to release? Like for example, Tron 2.0?

Note that it took quite some time to fully load the Library, and Firefox was pretty much non-responsive till it was done. But it's nice to have everything in one page again!

I also like the blue dot. Now, if you could also make the "NEW" tag appear that would be great. But please, don't make it grey - no more grey, please!!

#b00000, or at least #d70000, would be really nice.




Don't mean to ungrateful or anything, but I changed it to:

addGlobalStyle('.module-header.legacy.black, .account__pagination.legacy.black { color: #737373; }');
addGlobalStyle('.account__pagination.legacy.black .skin-selector__current, .account__pagination.legacy.black .skin-selector__dropdown-icon { color: #464646; }');

Much better for my poor ageing eyes!

As in the wood and black shelf colours?

The show hidden games should only come up if the only results are hidden (I think, it never shows up for me) so I'm not sure why it would show up at all...
Yeah, that's probably to be expected unfortunately. How is performance after the load? Is scrolling slow or is it ok?

I can look into it certainly, it shouldn't be too much trouble to put a 'New' tag in the other corner when required.

You mean scrolling through the Library? doesn't feel any different than with the 100/pg, and it is certainly smoother and quicker than it was when we had the GOG Legacy Shelf. Same goes for the the game art rendering.


Ah yes - "New", and not "NEW", would also be much appreciated. :-)

Yup, those. I think it's if at least one of them is hidden.
(Although there seems to be a bug on GOG's side that sometimes shows the option even when nothing's hidden. Not sure what that's about... but I guess it's not really relevant.)

Might be the same issues as Hyper reported earlier, I'll have to look into them properly and sort them, it's most likely due to not updating all the CSS and stuff when changing styles / pages etc.

Hmm.. it's never shown for me when I've had hidden games, not that I've noticed anyway.

Is this regardless of shelf style and/or view type?