It seems that you're using an outdated browser. Some things may not work as they should (or don't work at all).
We suggest you upgrade newer and better browser like: Chrome, Firefox, Internet Explorer or Opera

×
Community
General discussionAdalia Fundamentals - Fixing GoG so you don't have to!(3599 posts)(3599 posts)
(3599 posts)
Pages:
1
15
16
17
18
19
50
100
150
200
240
This is my favourite topic
Posted October 12, 2015
high rated
avatar
HypersomniacLive: What do you mean "you presume"? I did attach a screenshot, didn't I? Are you still scum playing it safe?
Always, I think at this point I'm second only to Krypsyn as a safe bet for scum...

Sorry I completely forgot you'd put a screenshot by the time I'd replied...
Posted October 13, 2015
high rated
Finally got a night to test out all the new changes (been a very busy last 3 days.) First of all, thank you so much for the new Legacy shelf, it is absolutely beautiful! I'm actually very happy that you decided to increase the size of the boxes, since it looks so much nicer on higher resolutions than the original shelf was. If only we could have more than one page of it.

Secondly, I'm missing box art for Alone in the Dark 1, 2, and 3 (assume because it's bought as a bundle). It'd be fine to just use the bundle image for all three games if GOG doesn't have images for each one individually.

Thirdly, I'd like to second Hyper's idea of having the shelf page controls at the top of the shelf. It really is annoying having to scroll down.

[Edit:] I changed my sort from a-z to purchase date and refreshed the page (only way to get it to reload box art currently) and wound up with a bunch more box arts missing, see attached.
[Edit2:] And sorting by newest first and oldest first reveal even more missing box arts after page refresh. I guess I'll just wait until you get the multiple pages working before I start reporting all the broken boxes.

Keep up the great work though, Adalia, really loving it all!
Attachments:
aflegacyshelf3.jpg (467 Kb)
Post edited October 13, 2015 by vulchor
Posted October 13, 2015
high rated
avatar
vulchor: Finally got a night to test out all the new changes (been a very busy last 3 days.) First of all, thank you so much for the new Legacy shelf, it is absolutely beautiful! I'm actually very happy that you decided to increase the size of the boxes, since it looks so much nicer on higher resolutions than the original shelf was. If only we could have more than one page of it.

Secondly, I'm missing box art for Alone in the Dark 1, 2, and 3 (assume because it's bought as a bundle). It'd be fine to just use the bundle image for all three games if GOG doesn't have images for each one individually.

Thirdly, I'd like to second Hyper's idea of having the shelf page controls at the top of the shelf. It really is annoying having to scroll down.

[Edit:] I changed my sort from a-z to purchase date and refreshed the page (only way to get it to reload box art currently) and wound up with a bunch more box arts missing, see attached.
[Edit2:] And sorting by newest first and oldest first reveal even more missing box arts after page refresh. I guess I'll just wait until you get the multiple pages working before I start reporting all the broken boxes.

Keep up the great work though, Adalia, really loving it all!
Thanks vulchor, glad you like it
Hmmm, the forgotten realms games may be a problem if they don't have unbundled boxes or if we can't find them... as they are actually different games there would be no way to tell which one was which with out clicking on them all...
Posted October 13, 2015
high rated
It won't be necessary to report all broken boxes, since we can figure at least most of them out. Comparing [url=http://www.gogwiki.com/wiki/User:Barry_Woodward]Barry's GOGWiki page[/url] to the current list of boxes, these IDs were left over:
1207660923, 1207660963, 1207660973, 1207661133, 1207667213, 1207667223, 1429023691, 1429024026, 1429878383, 1430392753, 1430912792, 1430913246, 1432575012, 1432576039, 1432576327, 1432578339, 1432579019, 1432640506, 1432640961, 1432641528, 1432641771, 1432642138, 1432643408, 1432649588, 1432650732, 1434535097, 1434535284, 1434536205, 1434538201, 1434538373, 1435735429, 1435828767, 1435828982, 1435829353, 1435848742, 1435848814, 1439995156, 1441705046, 1441705126, 1442218265, 1442473063

Now, if the script were to use bundle boxes as stand-ins for missing unbundled boxes, perhaps they could have text overlays with the game's title to differentiate between them? At least until custom covers were created...

And if we were to crowdsource some custom covers, what would be the best way to host them? (Perhaps something that doesn't rely on a single person... is this something GOGwiki could help with? I'm definitely overthinking this.)

P.S. My list currently gives this as the cover for 1207661133 (King's Quest 3). Sure, it has the wrong text on it, but so do some other existing boxes. They should probably be replaced by custom covers as well if that's the plan.

</incoherentbabble>
Posted October 13, 2015
high rated
avatar
plagren: It won't be necessary to report all broken boxes, since we can figure at least most of them out. Comparing [url=http://www.gogwiki.com/wiki/User:Barry_Woodward]Barry's GOGWiki page[/url] to the current list of boxes, these IDs were left over:
1207660923, 1207660963, 1207660973, 1207661133, 1207667213, 1207667223, 1429023691, 1429024026, 1429878383, 1430392753, 1430912792, 1430913246, 1432575012, 1432576039, 1432576327, 1432578339, 1432579019, 1432640506, 1432640961, 1432641528, 1432641771, 1432642138, 1432643408, 1432649588, 1432650732, 1434535097, 1434535284, 1434536205, 1434538201, 1434538373, 1435735429, 1435828767, 1435828982, 1435829353, 1435848742, 1435848814, 1439995156, 1441705046, 1441705126, 1442218265, 1442473063

Now, if the script were to use bundle boxes as stand-ins for missing unbundled boxes, perhaps they could have text overlays with the game's title to differentiate between them? At least until custom covers were created...

And if we were to crowdsource some custom covers, what would be the best way to host them? (Perhaps something that doesn't rely on a single person... is this something GOGwiki could help with? I'm definitely overthinking this.)

P.S. My list currently gives this as the cover for 1207661133 (King's Quest 3). Sure, it has the wrong text on it, but so do some other existing boxes. They should probably be replaced by custom covers as well if that's the plan.

</incoherentbabble>
Good work :)

Yeah, that's not a bad solution (although it would have to be done right to not spoil the look of the boxes), I was also thinking of adding the game title as a title attribute (so it shows on hover) to help identify games and boxes...

Probably GoG Wiki if that can be arranged (I can't see Barefoot and other admins having a problem with it) as at least that's a fairly sensible and stable place for them to be.

I only scraped the list once and built my own formatted one from that. I do intend to create something a bit more robust, but I want to get the other niggles ironed out first, once I can figure out the best way.
Posted October 13, 2015
Can it be that the legacy shelf does not show pictures when you change to the updated or the hidden games tab?

Because for me the hidden game has no picture but it might be part of the unbundling. And when I went to the updated category it showed Defenders Quest without a picture. Or is that because it normally is not on my first page?
Posted October 13, 2015
high rated
avatar
moonshineshadow: Can it be that the legacy shelf does not show pictures when you change to the updated or the hidden games tab?

Because for me the hidden game has no picture but it might be part of the unbundling. And when I went to the updated category it showed Defenders Quest without a picture. Or is that because it normally is not on my first page?
It's probably all to do with the same issue.

Basically I've added a property to the products that are first loaded that contains the url to the legacy box art, but when you reload the products the new ones don't get the url. Not quite so sure about the hidden games and updated ones (Defenders Quest seemed to load it's image for me when I went to Updated, but it's on my first page, whereas when I unhide my hidden games I don't think they had images because they obviously weren't loaded at the time...)

Tl:dr
It should all be sorted out at the same time once I figure out how to sort it out at all...
Posted October 13, 2015
high rated
If anyone with over 100 products has a minute to test something for me I'd be grateful.
I need you to run this code in the console:

Object.size = function(obj) {
var size = 0, key;
for (key in obj) {
if (obj.hasOwnProperty(key)) size++;
}
return size;
};
Object.size(angular.element(document.querySelectorAll('.list')).scope().products._accountProducts._account._ga meSeeker._customProductRepository._products);

And then change page and run it again.

Thanks :)
Posted October 13, 2015
avatar
adaliabooks: If anyone with over 100 products has a minute to test something for me I'd be grateful.
I need you to run this code in the console:

Object.size = function(obj) {
var size = 0, key;
for (key in obj) {
if (obj.hasOwnProperty(key)) size++;
}
return size;
};
Object.size(angular.element(document.querySelectorAll('.list')).scope().products._accountProducts._account._ga meSeeker._customProductRepository._products);

And then change page and run it again.

Thanks :)
I wanted to test it but I get:
SyntaxError: missing ) after argument list

But all brackets seem closed if I counted correctly.
Posted October 13, 2015
high rated
Well, the result increases by 100 for every new page. If that helps. :-P
(The syntax error is caused by the line break on "ga meSeeker")

Btw, would this be of any use? https://www.gog.com/account/getFilteredProducts?hiddenFlag=0&amp;mediaType=1&amp;page=1&amp;sortBy=release_date_asc&amp;totalPages=10
Post edited October 13, 2015 by plagren
Posted October 13, 2015
Second what moonshineshadow said.
Posted October 13, 2015
high rated
avatar
moonshineshadow: I wanted to test it but I get:
SyntaxError: missing ) after argument list

But all brackets seem closed if I counted correctly.
Odd... well, plagren's result tells me what I need (hopefully) so I wouldn't worry :)
Thanks for trying.

avatar
plagren: Well, the result increases by 100 for every new page. If that helps. :-P

Btw, would this be of any use? https://www.gog.com/account/getFilteredProducts?hiddenFlag=0&amp;mediaType=1&amp;page=1&amp;sortBy=release_date_asc&amp;totalPages=10
Yay!
That's what I expected it to do, that's a first...

Yeah, I know about the products URL, but I'm hoping not to have to load everything myself if I don't have to.

I was playing around the with filtering and sorting and realised that it only calls AJAX to that url when you add a filter, when you remove it it just reloads games. So they must be stored somewhere else that it loads them from in this instance. It also looks like when you load a new page it saves the games rather than just dumping the games from the previous page and replacing them, which again should make my job easier.

Getting closer I think...

Thanks guys :)
Posted October 13, 2015
high rated
avatar
moonshineshadow: I wanted to test it but I get:
SyntaxError: missing ) after argument list

But all brackets seem closed if I counted correctly.
avatar
adaliabooks: Odd... well, plagren's result tells me what I need (hopefully) so I wouldn't worry :)
Thanks for trying.
Hah, I found the problem.
The firefox console translates the line break which happens in the Object.size line in your post into a blank when copying it directly. And therefore the code does not work anymore. After deleting the blank it works :D
Posted October 13, 2015
avatar
moonshineshadow: Hah, I found the problem.
The firefox console translates the line break which happens in the Object.size line in your post into a blank when copying it directly. And therefore the code does not work anymore. After deleting the blank it works :D
Ah, I always forget about the forum's somewhat dodgy formatting of things...
Posted October 13, 2015
high rated
It's not a proper update, so you'll have to force an update, but I've tried something different to see if it works.

If someone could test it for me that would be great.

Just check if the additional pages show boxes now.
And there should (possibly) be some console output.

Thanks.
Pages:
1
15
16
17
18
19
50
100
150
200
240
This is my favourite topic
Community
General discussionAdalia Fundamentals - Fixing GoG so you don't have to!(3599 posts)(3599 posts)
(3599 posts)