It seems that you're using an outdated browser. Some things may not work as they should (or don't work at all).
We suggest you upgrade newer and better browser like: Chrome, Firefox, Internet Explorer or Opera

×
Community
General discussionAdalia Fundamentals - Fixing GoG so you don't have to!(3599 posts)(3599 posts)
(3599 posts)
Pages:
1
50
100
150
153
154
155
156
157
240
This is my favourite topic
Posted July 23, 2017
avatar
adaliabooks: I see it too, I'll have a look into it.

Thanks :)
:) Thank you !
Posted July 23, 2017
high rated
avatar
adaliabooks: I see it too, I'll have a look into it.

Thanks :)
avatar
Splatsch: :) Thank you !
I can't see anything obvious, in fact it looks like an error in Gog's data (but it's obviously not as it works without AF on), but they do seem to have significantly updated the Wishlist code since I worked on it so it may just be if I update it with the newer classes and bits it will fix it.
I'll try and get around to it as soon as I can.
Posted July 23, 2017
high rated
avatar
adaliabooks: I see it too, I'll have a look into it.

Thanks :)
Do you mean that you see it too on Pale Moon or on Chrome?

FWIW, it's also happening on Firefox (Anno 1404: Gold Edition) with the USD sign, though I assume that it's independent of currency selected.
Posted July 23, 2017
high rated
avatar
HypersomniacLive: Do you mean that you see it too on Pale Moon or on Chrome?

FWIW, it's also happening on Firefox (Anno 1404: Gold Edition) with the USD sign, though I assume that it's independent of currency selected.
In Chrome (with the pound sign)

It's ok, I've already fixed it. Gog must have changed how the data is stored for newer games at some point and changed the website code to match. The older games seemed to work and it was mainly newer ones that showed issues.

I just want to update the code for public wishlists in case there have been changes there and I'll push an update tonight or tomorrow.
Posted July 24, 2017
high rated
Right, just a minor update to fix the currency bug and make sure the wishlists are up to date (for now) for any other changes Gog might introduce.
Posted July 24, 2017
high rated
Nice to see such a fast response after a bug report, even if I never experienced the currency issue in my wishlist.

However, all this talk about currency symbols got me thinking about an old pet peeve of mine (feature request incoming). How difficult would it be for you to add the option to show the currency symbol after the price amount? I.e. for me it's weird to see a price like "€ 9.99", as "9.99 €" feels more natural. It's nothing critical of course, but it'd be grateful if you could add this option to AF. :)
Posted July 24, 2017
high rated
avatar
muntdefems: Nice to see such a fast response after a bug report, even if I never experienced the currency issue in my wishlist.

However, all this talk about currency symbols got me thinking about an old pet peeve of mine (feature request incoming). How difficult would it be for you to add the option to show the currency symbol after the price amount? I.e. for me it's weird to see a price like "€ 9.99", as "9.99 €" feels more natural. It's nothing critical of course, but it'd be grateful if you could add this option to AF. :)
Hmmm... it should technically be reasonably easy... would you want it all over the site though? (I presume so)

I'll have to have a look and see if there's any pattern to the way the prices work that could be easily manipulated, as the currency symbol tends to be a separate class and element (to facilitate changing currency) it should be possible to move the whole thing in most cases..
Posted July 24, 2017
high rated
avatar
adaliabooks: would you want it all over the site though? (I presume so)
Yep, I get triggered by Euro symbols before numbers in general, be them in the front page, a game card, my wishlist, or my orders history page. So if you could find a general way to do the placement swap that'd be great, but if you need to find a specific solution for each part of the GOG website, then don't bother.
Posted July 24, 2017
high rated
avatar
adaliabooks: would you want it all over the site though? (I presume so)
avatar
muntdefems: Yep, I get triggered by Euro symbols before numbers in general, be them in the front page, a game card, my wishlist, or my orders history page. So if you could find a general way to do the placement swap that'd be great, but if you need to find a specific solution for each part of the GOG website, then don't bother.
It all depends on how they do it unfortunately. If it's standardised across the site then one method should be usable on every page, but if they all use slightly different methods it would need customised further to work correctly.

Unfortunately, this is Gog so I imagine the second case is more likely...
Posted July 24, 2017
high rated
avatar
muntdefems: Yep, I get triggered by Euro symbols before numbers in general, be them in the front page, a game card, my wishlist, or my orders history page. So if you could find a general way to do the placement swap that'd be great, but if you need to find a specific solution for each part of the GOG website, then don't bother.
avatar
adaliabooks: It all depends on how they do it unfortunately. If it's standardised across the site then one method should be usable on every page, but if they all use slightly different methods it would need customised further to work correctly.

Unfortunately, this is Gog so I imagine the second case is more likely...
So I guess this quick update is not yet "next time?" ;)
https://www.gog.com/forum/general/adalia_fundamentals_fixing_gog_so_you_dont_have_to/post2303

No need to push yourself, of course. Just a friendly reminder :) Thank you for your great work.
Posted July 24, 2017
high rated
You were really fast, thank you very much :)
But there was really no need to hurry like some said previously ;) Thanks again for all your work !
Post edited July 24, 2017 by Splatsch
Posted July 24, 2017
high rated
avatar
MarkoH01: So I guess this quick update is not yet "next time?" ;)
https://www.gog.com/forum/general/adalia_fundamentals_fixing_gog_so_you_dont_have_to/post2303

No need to push yourself, of course. Just a friendly reminder :) Thank you for your great work.
Sorry, I forgot again. I'll get around to it, promise ;)
Posted July 24, 2017
high rated
Cheers for the super quick fix.


avatar
adaliabooks: Sorry, I forgot again. I'll get around to it, promise ;)
*cough... cough*
Posted July 24, 2017
high rated
avatar
muntdefems: Yep, I get triggered by Euro symbols before numbers in general, be them in the front page, a game card, my wishlist, or my orders history page. So if you could find a general way to do the placement swap that'd be great, but if you need to find a specific solution for each part of the GOG website, then don't bother.
avatar
adaliabooks: It all depends on how they do it unfortunately. If it's standardised across the site then one method should be usable on every page, but if they all use slightly different methods it would need customised further to work correctly.

Unfortunately, this is Gog so I imagine the second case is more likely...
There is a class on <html> tag "curr-symbol-after" or "curr-symbol-before". :) Enjoy.

Sidenote: Rules for currency symbol side are defined per-language (e.g. en=left, fr=right), with exceptions for some currencies. An example of an exception is PLN for EN language - where currency is on the right side.
Posted July 24, 2017
high rated
avatar
Johny.: There is a class on <html> tag "curr-symbol-after" or "curr-symbol-before". :) Enjoy.

Sidenote: Rules for currency symbol side are defined per-language (e.g. en=left, fr=right), with exceptions for some currencies. An example of an exception is PLN for EN language - where currency is on the right side.
LOL, it never occurred to me to change the language to French or German. But that doesn't do it for me as I'd rather have the website in English, but with the € symbol after instead of before.

In fact, I'd prefer the currency symbol side rules to be currency-based rather than language-based. Because a price like "9.99 $" looks as bizarre to me as one like "€ 9.99" does. :\
Pages:
1
50
100
150
153
154
155
156
157
240
This is my favourite topic
Community
General discussionAdalia Fundamentals - Fixing GoG so you don't have to!(3599 posts)(3599 posts)
(3599 posts)