It seems that you're using an outdated browser. Some things may not work as they should (or don't work at all).
We suggest you upgrade newer and better browser like: Chrome, Firefox, Internet Explorer or Opera

×
Community
General discussionAdalia Fundamentals - Fixing GoG so you don't have to!(3599 posts)(3599 posts)
(3599 posts)
Pages:
1
14
15
16
17
18
50
100
150
200
240
This is my favourite topic
Posted October 11, 2015
high rated
Anyway, I've made a small change to the script.
I haven't changed the version number so you'll have to force an update. But if someone wouldn't mind doing so and checking the pages in the library I would be grateful :)
avatar
plagren: I assume they just don't exist, since GOG has no reason to make boxes for new unbundled games.

On the other hand, they still appear to be making other boxes that aren't used anywhere on the site except GOGmixes... which is a bit weird. So who knows.
Ah, I see.

I suppose we can just use the unbundled version, it would be better than nothing...

Who knows why they do anything?
Post edited October 11, 2015 by adaliabooks
Posted October 11, 2015
high rated
avatar
adaliabooks: Anyway, I've made a small change to the script.
I haven't changed the version number so you'll have to force an update. But if someone wouldn't mind doing so and checking the pages in the library I would be grateful :)
[...]

Who knows why they do anything?
No change for me - not that you were expecting anything earth shattering from my feedback.

FWIW, I've disabled every style and script I use on GOG, and even tested it on my SWare Iron browser (no add-ons or scripts/styles beyond TamperMonkey, BE and AF) - the Legacy Shelf still looks as in the screenshot I attached in my previous post.
Post edited October 12, 2015 by HypersomniacLive
Posted October 11, 2015
high rated
avatar
HypersomniacLive: No change for me - not that you were expecting anything earth shuttering from my feedback.

FWIW, I've disabled every style and script I use on GOG, and even tested it on my SWare Iron browser (no add-ons or scripts/styles beyond TamperMonkey, BE and AF) - the Legacy Shelf still looks as in the screenshot I attached in my previous post.
Oh well, didn't think it was going to fix it, but it was worth a try.

Thanks for trying Hyper... I have no idea what it can be then if it's not the resolution or a script interfering..
From the picture it looks like the margins and padding are off just a bit, is it right that there are only four games per row?
But it also looks the top and bottom are off and that's why they don't sit right on the shelf...
Are they getting worse as it goes down again? Or are the margins off by the same amount all the way down?
Posted October 12, 2015
high rated
avatar
adaliabooks: Oh well, didn't think it was going to fix it, but it was worth a try.

Thanks for trying Hyper... I have no idea what it can be then if it's not the resolution or a script interfering..
From the picture it looks like the margins and padding are off just a bit, is it right that there are only four games per row?
But it also looks the top and bottom are off and that's why they don't sit right on the shelf...
Are they getting worse as it goes down again? Or are the margins off by the same amount all the way down?
Yes, only four games per row. Not sure if it's clear enough in the screenshot, but there's not enough space left on the shelf to fit a fifth game due to the first four being too spaced out.

And no, it's not getting worse as it goes down, boxes are off by the same amount up to the very last row.


Request: Now that I said last row - is it possible to add that paginaitng thing to the top of the page? Sometimes I want to jump to a specific page, and it's annoying to first have to scroll all the way down the first page to do it.
Posted October 12, 2015
high rated
avatar
HypersomniacLive: Yes, only four games per row. Not sure if it's clear enough in the screenshot, but there's not enough space left on the shelf to fit a fifth game due to the first four being too spaced out.

And no, it's not getting worse as it goes down, boxes are off by the same amount up to the very last row.

Request: Now that I said last row - is it possible to add that paginaitng thing to the top of the page? Sometimes I want to jump to a specific page, and it's annoying to first have to scroll all the way down the first page to do it.
Hmmm.... I'll have a look and see if there are any styles that might make any difference further down the list...

Yes, probably. It may have to wait until I can test it properly but I think it should be possible.
Posted October 12, 2015
This is nothing serious so just do it if you are bored or have too much time :D

With the legacy shelf the left edge is smaller than the right one. Any chance this could be symmetric?
Attachments:
shelf_edge.jpg (196 Kb)
Posted October 12, 2015
high rated
avatar
moonshineshadow: This is nothing serious so just do it if you are bored or have too much time :D

With the legacy shelf the left edge is smaller than the right one. Any chance this could be symmetric?
I've just put a new update up with (hopefully) a fix for Hyper's odd shelf issue, and I've tweaked the shelf so it should be more symmetrical. It's tricky because too much and it bumps the box onto the next shelf... but that should be ok.

Edit:

Is it still necessary to keep a change log in the thread now that there is a proper one in the script? I suppose it means you could check what's changed before updating...
Also, is it still necessary for there to be version numbers outside the menu? (on the reviews filter and search bar)
Post edited October 12, 2015 by adaliabooks
Posted October 12, 2015
avatar
moonshineshadow: This is nothing serious so just do it if you are bored or have too much time :D

With the legacy shelf the left edge is smaller than the right one. Any chance this could be symmetric?
avatar
adaliabooks: I've just put a new update up with (hopefully) a fix for Hyper's odd shelf issue, and I've tweaked the shelf so it should be more symmetrical. It's tricky because too much and it bumps the box onto the next shelf... but that should be ok.

Edit:

Is it still necessary to keep a change log in the thread now that there is a proper one in the script? I suppose it means you could check what's changed before updating...
Also, is it still necessary for there to be version numbers outside the menu? (on the reviews filter and search bar)
Thanks :-)

In regards to the changelog. I would say it is nice to have the newest update also here in the thread, the older ones could be deleted should you reach the character limit for your post :D

And I think there is no need for showing the version number on the review filters.
Posted October 12, 2015
high rated
Tada! You're a magician, +1!!

Regarding the changelog - I'd say do what mrkgnao and Barefoot_Monkey do - make posts for new updates in here as they become available, and just add a note in the OP that you're going about it this way.

I like having the version number in the search bar, and I don't mind it in the reviews. If you're to keep it in the reviews, I'd go with a smaller and more discrete font choice. JMO
Attachments:
gog_legacyshelf2.png (279 Kb)
Posted October 12, 2015
high rated
avatar
adaliabooks: Is it missing completely? Or just missed off the list?

We may have to if GoG stop supporting them and making them for new games...
avatar
plagren: I assume they just don't exist, since GOG has no reason to make boxes for new unbundled games.

On the other hand, they still appear to be making other boxes that aren't used anywhere on the site except GOGmixes... which is a bit weird. So who knows.
I just attempted to create a new gogmix and was able to pick System Shock from the menu and get what looks like a box.


avatar
HypersomniacLive: No change for me - not that you were expecting anything earth shuttering from my feedback.
For adalia:
Shuttering? SHUTTERING?! -1 to Melee Skills for you (this way you'll have an extra skill point to invest in Language Skills)!
Post edited October 12, 2015 by mrkgnao
Posted October 12, 2015
high rated
avatar
mrkgnao: I just attempted to create a new gogmix and was able to pick System Shock from the menu and get what looks like a box.
Yup - but (as far as we can tell) the unbundled "Classic Edition" and "Enhanced Edition" don't have their own boxes.
Of course, the "Enhanced Edition" one would presumably be identical to the bundle box anyway.

(Am I making any sense? I think I could use a Language Skill buff too...)
Post edited October 12, 2015 by plagren
Posted October 12, 2015
high rated
avatar
HypersomniacLive: Tada! You're a magician, +1!!
I presume that means it worked? Good :)

avatar
mrkgnao: For adalia:
Shuttering? SHUTTERING?! -1 to Melee Skills for you (this way you'll have an extra skill point to invest in Language Skills)!
ROFL
Thanks ;)


And thanks everyone for the feedback, I'll take it all on board :)
Posted October 12, 2015
high rated
avatar
mrkgnao: I just attempted to create a new gogmix and was able to pick System Shock from the menu and get what looks like a box.
avatar
plagren: Yup - but (as far as we can tell) the unbundled "Classic Edition" and "Enhanced Edition" don't have their own boxes.
Of course, the "Enhanced Edition" one would presumably be identical to the bundle box anyway.

(Am I making any sense? I think I could use a Language Skill buff too...)
Got it. We lack a box that reads "Classic" instead of "Enhanced".

But we do have the enhanced box, yet it is not displayed, judging from HSL's screenshot, perhaps because of different ID issues.
Posted October 12, 2015
high rated
avatar
mrkgnao: Got it. We lack a box that reads "Classic" instead of "Enhanced".

But we do have the enhanced box, yet it is not displayed, judging from HSL's screenshot, perhaps because of different ID issues.
Yeah, right now I've just used plagren's list and based it off the library ids. Once I implement it properly if there is no image for the library id but it has a bundle id (catalogue one) then I would use the image for that instead.
I'll also implement a system where any images not found at all get sent to be auto checked and updated, but I want to try and fix the pagination issues first before moving on to a proper database implementation.
Posted October 12, 2015
high rated
avatar
mrkgnao: [...]

For adalia:
Shuttering? SHUTTERING?! -1 to Melee Skills for you (this way you'll have an extra skill point to invest in Language Skills)!
I could argue that I'm not a native English speaker, was already very very late, and I was very very tired and still sick... but I'll just say
touché.



avatar
adaliabooks: I presume that means it worked? Good :)

[...]
What do you mean "you presume"? I did attach a screenshot, didn't I? Are you still scum playing it safe?
Pages:
1
14
15
16
17
18
50
100
150
200
240
This is my favourite topic
Community
General discussionAdalia Fundamentals - Fixing GoG so you don't have to!(3599 posts)(3599 posts)
(3599 posts)