It seems that you're using an outdated browser. Some things may not work as they should (or don't work at all).
We suggest you upgrade newer and better browser like: Chrome, Firefox, Internet Explorer or Opera

×
high rated
avatar
HypersomniacLive: I wish I could express my appreciation for your work in a more direct way but I'm currently literally broke, so that is the least I can do for everything you're doing for us.
I know how you feel :)
It's the thought that counts, I really appreciate it, if I could reward you guys for helping with the testing I would.

avatar
HypersomniacLive: Ha, I wanted to suggest AF as the text for this button. I like it, and I don't mind the hover-over effects, but can live without them if others would rather not have them.

I would also suggest against a search bar at the bottom, things are cluttered enough there as it is.

And may I suggest a different colour for this button? If you're going for the colours of the old GOG logo, perhaps use the (darkest shade of) green?
Great minds? ;)

Yeah, fair point. I doubt anyone would look down there for it anyway, it was just a thought when I realised the button had shown up down there accidentally.

I like it, green it is :)
high rated
So, I'm playing around with the library to try and see about changing the number of games per page.

According to the javascript, there should be some variables to govern this, and it should be relatively easy to change said variables and not have to rebuild the whole system from scratch.

The only problem is, I can't find these variables, and I'm wondering if it's because I only have one page of games I can't see them (I don't really expect it is the case because I would expect something to still show, but you never know).

So if someone with over 100 games (that shouldn't be too hard an ask around here.. XD) could run these lines of code in their console and tell me if there are any results I would be grateful.

angular.element(document.querySelectorAll('.list-inner')).scope().amountOfProductsPerPage;
angular.element(document.querySelectorAll('.list-inner')).scope().allProducts;

I'm not really expecting them to turn up anything other than undefined, but it's worth checking....
high rated
avatar
adaliabooks: So if someone with over 100 games (that shouldn't be too hard an ask around here.. XD) could run these lines of code in their console and tell me if there are any results I would be grateful.

angular.element(document.querySelectorAll('.list-inner')).scope().amountOfProductsPerPage;
angular.element(document.querySelectorAll('.list-inner')).scope().allProducts;

I'm not really expecting them to turn up anything other than undefined, but it's worth checking....
Both undefined.
high rated
avatar
mrkgnao: Both undefined.
:/

Thanks mrkgnao,

That's what I expected, but at least I can rule that out for now.
DELETED nevermind question already answered. Sorry!
Post edited October 10, 2015 by yogsloth
high rated
avatar
yogsloth: DELETED nevermind question already answered. Sorry!
Awh... but now I want to know what it was....

:/
high rated
avatar
plagren: I've been meaning to do this for a while anyway, so... I worked out the URLs for all the old box art I know of, left out what's already available through the GOGmix interface, and was left with these: http://larkku.iki.fi/nongogmixboxart.html

[EDIT: Yeah, I'm just listing *all* the links now, whether they're on the GOGmix thingy or not.]

Since I'm matching the covers with game IDs manually, there's probably some errors.
Even if not useful for the script, maybe someone besides me will find these interesting. :-P
Lol.. I've been messing about wondering how to compile a list like this and hadn't checked back and realised you've already done it... XD

I just need to figure out the best way to use it now...
high rated
New update is here!

With huge thanks to plagren for his work compiling the list of IDs and URLs, we now have the Legacy Shelf :)

I've also added another new style which I've called Remix, which is the new shelf but minus the text block for the title (so like my Legacy Remix, but with the new style shelves and no background)

There may be a few errors and missing images on the Legacy Shelf, please report any that you find here and I'll try and fix them.

This solution (I've basically just created a list in a Javascript file on gist which it references) is only temporary, I'll try and set up some kind of proper hosting situation that will also update the list with new titles as required.
high rated
avatar
adaliabooks: New update is here!

With huge thanks to plagren for his work compiling the list of IDs and URLs, we now have the Legacy Shelf :)
First: Thanks for all the work.

So the legacy shelf is showing seven games per row which makes the end of a page having empty spaces since clearly 100 games per page is not divide-able by 7 ;-)

Also the pictures only work on the first page. On pages after that all images are missing.

Also is there an option to turn of this tiny search button? I am not using the search function and it is annoying as hell to me.
Attachments:
Post edited October 11, 2015 by moonshineshadow
high rated
avatar
moonshineshadow: First: Thanks for all the work.

So the legacy shelf is showing seven games per row which makes the end of a page having empty spaces since clearly 100 games per page is not divide-able by 7 ;-)

Also the pictures only work on the first page. On pages after that all images are missing.

Also is there an option to turn of this tiny search button? I am not using the search function and it is annoying as hell to me.
No problem :)

Yeah, I thought that would probably be an issue. It wasn't intentional, just happened when I decreased the width of the boxes. If I add some padding or margins in between them it should fix it.

As for the pages... I'm having trouble working with the multiple pages as I only have enough games to fill 1 page so can't really test behaviour...
If you wouldn't mind testing a couple of things for me I might be able to sort it though as I know why it will be doing that (the url variable is only set for the first lot of games so when it updates them it won't put it on the new ones)

The little tab at the top of the forum? Yeah, I can put an option to disable it completely from the menu if you'd prefer.
avatar
moonshineshadow: First: Thanks for all the work.

So the legacy shelf is showing seven games per row which makes the end of a page having empty spaces since clearly 100 games per page is not divide-able by 7 ;-)

Also the pictures only work on the first page. On pages after that all images are missing.

Also is there an option to turn of this tiny search button? I am not using the search function and it is annoying as hell to me.
avatar
adaliabooks: As for the pages... I'm having trouble working with the multiple pages as I only have enough games to fill 1 page so can't really test behaviour...
If you wouldn't mind testing a couple of things for me I might be able to sort it though as I know why it will be doing that (the url variable is only set for the first lot of games so when it updates them it won't put it on the new ones)

The little tab at the top of the forum? Yeah, I can put an option to disable it completely from the menu if you'd prefer.
I don't mind testing stuff, so just tell me what you need me to do :-)

And yes this little box thing where I can click on to open the search bar. I know it is only small, but it upsets the symmetrie of the site and is kinda irritating for me. So an option to disable it would be great.
high rated
avatar
moonshineshadow: I don't mind testing stuff, so just tell me what you need me to do :-)

And yes this little box thing where I can click on to open the search bar. I know it is only small, but it upsets the symmetrie of the site and is kinda irritating for me. So an option to disable it would be great.
No problem, I've set an option to completely disable search entirely (the button will still show when it's enabled though, not much I can do about that other than finding somewhere else for it..)

I've come up with two solutions to the boxs per row issue, the first is to shrink the shelf width (which doesn't quite look right as it gets a bit lost) or the second is to make the boxes bigger (while keeping the ratio the same so they look right). I've attached an image of the bigger box version to see what you think (I think it's the better option, but I'm not sure if people want the legacy shelf exactly as it was)

As for testing, if you can go to your library and put this in the console:
angular.element(document.body).injector().get('accountProducts')._products.length;

And tell me what the result is. I'm expecting it to either be 100 or the number of games in your library (and hoping for the later)
If it contains what I hope it does then we can do a little further testing to check if it's pre filtered and sorted, but lets just see how the first bit goes.
Attachments:
high rated
I've not updated yet, should I wait until we settle down on how the Legacy Shelf will look, and work?

I'm OK with the exact look the legacy shelf had (including the black version ;-D), and even the default style has five titles per row.
Not sure if doable, or even wanted by others, but perhaps go for ten per row, and see how that looks?
As for testing, if you can go to your library and put this in the console:
angular.element(document.body).injector().get('accountProducts')._products.length;
I've run it, and I'm sorry to say that the result is not the hoped for one:

angular.element(document.body).injector().get('accountProducts')._products.length;
100


On a side note, whenever I open my console I get the following which I assume is because of the Legacy Shelf?
Legacy Remix account:8:43
Error: Permission denied to access object 7d5bbd2-b9a9184.js:7:23846
pc/this.$get</n.prototype.$eval@[url=https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:8:6164]https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:8:6164[/url]
pc/this.$get</n.prototype.$digest@[url=https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:8:4591]https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:8:4591[/url]
pc/this.$get</n.prototype.$evalAsync/<@[url=https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:8:6253]https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:8:6253[/url]
e@[url=https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:6:21060]https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:6:21060[/url]
eb/l.defer/c<@[url=https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:6:22491]https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:6:22491[/url]
avatar
moonshineshadow: I don't mind testing stuff, so just tell me what you need me to do :-)

And yes this little box thing where I can click on to open the search bar. I know it is only small, but it upsets the symmetrie of the site and is kinda irritating for me. So an option to disable it would be great.
avatar
adaliabooks: No problem, I've set an option to completely disable search entirely (the button will still show when it's enabled though, not much I can do about that other than finding somewhere else for it..)
Oh that is great! Since I don't use the search normally I am completely fine with it being there when using it :P

And as Hyper said, the command is showing "100"
Post edited October 11, 2015 by moonshineshadow
high rated
avatar
HypersomniacLive: I've not updated yet, should I wait until we settle down on how the Legacy Shelf will look, and work?

I'm OK with the exact look the legacy shelf had (including the black version ;-D), and even the default style has five titles per row.
Not sure if doable, or even wanted by others, but perhaps go for ten per row, and see how that looks?

As for testing, if you can go to your library and put this in the console:
angular.element(document.body).injector().get('accountProducts')._products.length;
avatar
HypersomniacLive: I've run it, and I'm sorry to say that the result is not the hoped for one:

angular.element(document.body).injector().get('accountProducts')._products.length;
100

On a side note, whenever I open my console I get the following which I assume is because of the Legacy Shelf?

Legacy Remix account:8:43
Error: Permission denied to access object 7d5bbd2-b9a9184.js:7:23846
pc/this.$get</n.prototype.$eval@[url=https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:8:6164]https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:8:6164[/url]
pc/this.$get</n.prototype.$digest@[url=https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:8:4591]https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:8:4591[/url]
pc/this.$get</n.prototype.$evalAsync/<@[url=https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:8:6253]https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:8:6253[/url]
e@[url=https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:6:21060]https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:6:21060[/url]
eb/l.defer/c<@[url=https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:6:22491]https://www4-static4.gog.com/js/7d5bbd2-b9a9184.js:6:22491[/url]
avatar
HypersomniacLive:
I doubt ten per shelf would be doable as the boxes would have to be really small...

Thanks Hyper... too much to hope for :(

Yeah, it's to do with the shelf styles implementation (or the downloader links, I can't remember)... I'm just not sure why. It's the kind of bug I was getting with the reviews when they wouldn't work on Firefox, but this one doesn't seem to be breaking anything... I'm just not sure what variable I've changed that it can't access now. I'll have another hunt about and see if I can spot it, but as long as everything works I'm not too worried (GoG's base site throws up errors for me quite a bit too, although that may not be the best benchmark...)

I'll keep poking about and see if I can find the best and easiest way to sort multiple pages and changing the amount of products per page.
avatar
moonshineshadow: Oh that is great! Since I don't use the search normally I am completely fine with it being there when using it :P

And as Hyper said, the command is showing "100"
No problem :)
I'll probably push another update in a bit with the extra stuff.

Thanks moon :)
Post edited October 11, 2015 by adaliabooks